From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755690AbbICO0v (ORCPT ); Thu, 3 Sep 2015 10:26:51 -0400 Received: from muru.com ([72.249.23.125]:48376 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754622AbbICO0u (ORCPT ); Thu, 3 Sep 2015 10:26:50 -0400 Date: Thu, 3 Sep 2015 07:26:46 -0700 From: Tony Lindgren To: santosh shilimkar Cc: "Kwok, WingMan" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "linux@arm.linux.org.uk" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "ssantosh@kernel.org" , "Karicheri, Muralidharan" Subject: Re: [PATCH] ARM: dts: keystone: use one to one address translations under netcp Message-ID: <20150903142645.GS4215@atomide.com> References: <1441139324-29296-1-git-send-email-w-kwok2@ti.com> <55E61658.9010207@oracle.com> <230CBA6E4B6B6B418E8730AC28E6FC7E04221776@DFLE11.ent.ti.com> <55E71AB3.7070406@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E71AB3.7070406@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * santosh shilimkar [150902 08:55]: > > I suspected the same. I know back then we started with SERDES code > with NETCP but as you already know, its a separate block which > is needed for NIC card to work. Its more of phy and hence its > having different address space is not surprising. The point Santosh is making here though is that any drivers tinkering with registers belonging to a separate hardware block is a recipe for a long term maintenance nightmare with mysterious bugs popping up as things are not clocked or powered properly or become racy with other drivers. Each hardware block needs to have it's own driver and then the drivers can communicate using some Linux generic APIs like clock, regulator, phy, or mailbox frameworks. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: keystone: use one to one address translations under netcp Date: Thu, 3 Sep 2015 07:26:46 -0700 Message-ID: <20150903142645.GS4215@atomide.com> References: <1441139324-29296-1-git-send-email-w-kwok2@ti.com> <55E61658.9010207@oracle.com> <230CBA6E4B6B6B418E8730AC28E6FC7E04221776@DFLE11.ent.ti.com> <55E71AB3.7070406@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55E71AB3.7070406-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: santosh shilimkar Cc: "Kwok, WingMan" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "Karicheri, Muralidharan" List-Id: devicetree@vger.kernel.org * santosh shilimkar [150902 08:55]: > > I suspected the same. I know back then we started with SERDES code > with NETCP but as you already know, its a separate block which > is needed for NIC card to work. Its more of phy and hence its > having different address space is not surprising. The point Santosh is making here though is that any drivers tinkering with registers belonging to a separate hardware block is a recipe for a long term maintenance nightmare with mysterious bugs popping up as things are not clocked or powered properly or become racy with other drivers. Each hardware block needs to have it's own driver and then the drivers can communicate using some Linux generic APIs like clock, regulator, phy, or mailbox frameworks. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 3 Sep 2015 07:26:46 -0700 Subject: [PATCH] ARM: dts: keystone: use one to one address translations under netcp In-Reply-To: <55E71AB3.7070406@oracle.com> References: <1441139324-29296-1-git-send-email-w-kwok2@ti.com> <55E61658.9010207@oracle.com> <230CBA6E4B6B6B418E8730AC28E6FC7E04221776@DFLE11.ent.ti.com> <55E71AB3.7070406@oracle.com> Message-ID: <20150903142645.GS4215@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * santosh shilimkar [150902 08:55]: > > I suspected the same. I know back then we started with SERDES code > with NETCP but as you already know, its a separate block which > is needed for NIC card to work. Its more of phy and hence its > having different address space is not surprising. The point Santosh is making here though is that any drivers tinkering with registers belonging to a separate hardware block is a recipe for a long term maintenance nightmare with mysterious bugs popping up as things are not clocked or powered properly or become racy with other drivers. Each hardware block needs to have it's own driver and then the drivers can communicate using some Linux generic APIs like clock, regulator, phy, or mailbox frameworks. Regards, Tony