From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758045AbbIDHFP (ORCPT ); Fri, 4 Sep 2015 03:05:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44149 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbbIDHFN (ORCPT ); Fri, 4 Sep 2015 03:05:13 -0400 Date: Fri, 4 Sep 2015 09:05:07 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Adrian Hunter , kan.liang@intel.com, mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [tip:perf/urgent] perf evlist: Open event on evsel cpus and threads Message-ID: <20150904070507.GC24774@krava.redhat.com> References: <1440138194-17001-1-git-send-email-kan.liang@intel.com> <55E84C60.4010309@intel.com> <20150903152713.GA2537@redhat.com> <55E8740F.1010107@intel.com> <20150903164109.GB2537@redhat.com> <20150903181939.GA20908@krava.redhat.com> <20150903204106.GA2570@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150903204106.GA2570@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2015 at 05:41:06PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Sep 03, 2015 at 08:19:39PM +0200, Jiri Olsa escreveu: > > On Thu, Sep 03, 2015 at 01:41:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Sep 03, 2015 at 07:23:43PM +0300, Adrian Hunter escreveu: > > > > On 3/09/2015 6:27 p.m., Arnaldo Carvalho de Melo wrote: > > > > >Em Thu, Sep 03, 2015 at 04:34:24PM +0300, Adrian Hunter escreveu: > > > > >>On 01/09/15 11:31, tip-bot for Kan Liang wrote: > > > > >Something we could catch in a 'test' entry? Even if that required Intel > > > > >PT hardware that would be something important to have, all this stuff is > > > > >growing in complexity, we need those tests... > > > > > There is "Test tracking with sched_switch" but you need to expose it > > > > to the same issue i.e. > > > > Sure, Kan and Jiri were talking about the need to go doing these > > > changes, Jiri? Kan? > > > perf_evlist__propagate_maps is called from perf_evlist__create_maps, > > so if evsel is added later it will not be affected, perhaps we need > > something like below: > > > +++ b/tools/perf/util/evlist.c > > @@ -133,6 +133,9 @@ void perf_evlist__add(struct perf_evlist *evlist, struct perf_evsel *entry) > > > > if (!evlist->nr_entries++) > > perf_evlist__set_id_pos(evlist); > > + > > + entry->cpus = cpu_map__get(evlist->cpus); > > + entry->threads = thread_map__get(evlist->threads); > > You can't simply do that, we need to do it only if those fields are not > already set. argh, right.. forgot about cpus setup.. anyway, Adrian already wanted to do single function for this and the propagate function jirka