All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: read dpcd 0 - 12 & link_status always
Date: Fri, 4 Sep 2015 09:46:20 +0200	[thread overview]
Message-ID: <20150904074620.GE22430@phenom.ffwll.local> (raw)
In-Reply-To: <87a8t31yhr.fsf@intel.com>

On Thu, Sep 03, 2015 at 03:25:04PM +0300, Jani Nikula wrote:
> On Wed, 02 Sep 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Sep 01, 2015 at 01:16:49PM +0300, Jani Nikula wrote:
> >> On Thu, 27 Aug 2015, Sivakumar Thulasimani <sivakumar.thulasimani@intel.com> wrote:
> >> > From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
> >> >
> >> > Compliance requires the driver to read dpcd register 0 to 12 and
> >> > registers 0x200 to 0x205 to be read always.
> >> > Current code performs dpcd read for short pulse interrupts only
> >> > if the sink is enabled. This patch forces read for link status
> >> > and registers 0 to 12.
> >> 
> >> While this seems a bit silly from the driver perspective, I don't see it
> >> doing much harm either.
> >
> > I don't think this is silly, but fixing it like this might be - currently
> > we don't do _any_ detection of sink ports, so if you have a hub with two
> > outputs and then plug in another one and plug out the first userspace
> > won't reprobe. So probably what we should be doing is not just read the
> > dpcd, but actually look at it, figure out whether something has changed
> > and make sure we send out the uevent even if the hpd line stays unchanged
> > on short pulses to make userspace aware of the changes.
> >
> > Punting on this for now since I suspect there's a bigger story to be had
> > here ...
> 
> Well, I'll bet this would be a preliminary step for that anyway.

Then the commit message should explain that. Adding code that's not needed
just for compliance to be happy just feels very fishy. And if we have more
work to do won't really gain us much since for the full monty we probably
need to juggle a few pieces in the overall picture.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-09-04  7:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  8:48 [PATCH 0/4] Detect DP displays based on sink count change Sivakumar Thulasimani
2015-08-27  8:48 ` [PATCH 1/4] drm/i915: read dpcd 0 - 12 & link_status always Sivakumar Thulasimani
2015-09-01 10:16   ` Jani Nikula
2015-09-02  9:04     ` Daniel Vetter
2015-09-03 12:25       ` Jani Nikula
2015-09-04  7:46         ` Daniel Vetter [this message]
2015-08-27  8:48 ` [PATCH 2/4] drm/i915: read sink_count dpcd always Sivakumar Thulasimani
2015-09-01 10:29   ` Jani Nikula
2015-09-01 11:54     ` Sivakumar Thulasimani
2015-09-01 13:15       ` Jani Nikula
2015-09-01 14:24         ` Sivakumar Thulasimani
2015-08-27  8:48 ` [PATCH 3/4] drm/i915: Save sink_count for tracking changes to it Sivakumar Thulasimani
2015-09-01 10:43   ` Jani Nikula
2015-08-27  8:48 ` [PATCH 4/4] drm/i915: force full detect on sink count change Sivakumar Thulasimani
2015-09-01 10:42   ` Jani Nikula
2015-09-01 11:39     ` Sivakumar Thulasimani
2015-09-01 13:04       ` Jani Nikula
2015-09-02  9:13   ` Daniel Vetter
2015-09-03  8:24     ` Sivakumar Thulasimani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150904074620.GE22430@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.