From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760141AbbIDQm5 (ORCPT ); Fri, 4 Sep 2015 12:42:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:40192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759307AbbIDQm4 (ORCPT ); Fri, 4 Sep 2015 12:42:56 -0400 Date: Fri, 4 Sep 2015 13:42:51 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Matt Fleming , =?iso-8859-1?Q?Rapha=EBl?= Beamonte , Steven Rostedt Subject: Re: [PATCH 12/15] tools lib api: Add configured support for fs Message-ID: <20150904164251.GE3284@kernel.org> References: <1441180605-24737-1-git-send-email-jolsa@kernel.org> <1441180605-24737-13-git-send-email-jolsa@kernel.org> <20150902133931.GH12722@kernel.org> <20150902134625.GC27164@krava.brq.redhat.com> <20150902141759.GK12722@kernel.org> <20150902165228.GL12722@kernel.org> <20150904070845.GD24774@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150904070845.GD24774@krava.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 04, 2015 at 09:08:45AM +0200, Jiri Olsa escreveu: > On Wed, Sep 02, 2015 at 01:52:28PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Sep 02, 2015 at 11:17:59AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Sep 02, 2015 at 03:46:25PM +0200, Jiri Olsa escreveu: > > > > On Wed, Sep 02, 2015 at 10:39:31AM -0300, Arnaldo Carvalho de Melo wrote: > > > > > Em Wed, Sep 02, 2015 at 09:56:42AM +0200, Jiri Olsa escreveu: > > > > > > Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs) > > > > > > The cut'n'paste error I mentioned was in the above line, BTW. > > > > > > > > > interface that returns bool state of the filesystem mount: > > > > > > true - mounted, false - not mounted > > > > > > > > > > Well, why not take the opportunity and call it... name__mounted()? > > > > > "__configured()" is too vague... > > > > > > > > I mirrored the debugfs/tracefs object interface > > > > we can have another patch changing that > > > > > > Ok, agreed, will leave it as configured() and then we can change it. > > > > What I have is at my tmp.perf/core branch, out for lunch. > > I can see all of it in your's perf/core apart from: > > Applying: tools lib api: Make tracing_path_strerror_open message generic > Applying: tools lib api: Replace debugfs/tracefs objects interface with fs.c > Applying: tools lib api: Remove debugfs, tracefs and findfs objects > Applying: perf tools: Switch to tracing_path interface on appropriate places > > should I repost or do you plan to take it? I didn't get any comments on those I'll get back to those, its just that the number of patches in my perf/core branch was getting too high, better flush it a bit, will continue. If you can just make sure that a rebase on top of my perf/core goes well, that helps. - Arnaldo