All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Zhao Lei <zhaolei@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: scrub: set error stats when tree block spanning stripes
Date: Mon, 7 Sep 2015 14:37:44 +0200	[thread overview]
Message-ID: <20150907123744.GU11834@suse.cz> (raw)
In-Reply-To: <55E90E21.9020004@cn.fujitsu.com>

On Fri, Sep 04, 2015 at 11:21:05AM +0800, Qu Wenruo wrote:
> I'm happy and willing to add the relocating ability for btrfs-progs.
> As that will provide a lot of flexibility, while the code should be 
> quite easy if I do it in a NOCOW method.
> (Find a extent, copy it to other place, follow backref and modify)
> 
> The only concern is, does it mean that we need to implement all the 
> features of btrfs kernel in user space tool?

I don't think we need a 1:1 feature parity. We might end up doing a one
chunk relocation, but relocating an extent would be enough for a start.

Doing the operations in userspace is easier in some respects as the data
are not live, we can do different trade-offs, utilize readahead etc.
Some operations might end up significantly faster and might be used as
one-time actions eg. when converting multi-terabyte filesystem to
another raid type. But this is a long-term goal.

> And will it make the codes duplicated between kernel and progs?

At this moment the code is not unified and we have to copy the code from
kernel where needed. But as far as the code does not diverge, it'll be
easier to use exact kernel sources in progs. Current versions of the
common sources are not close enough, so we'd have to unify them first.

      reply	other threads:[~2015-09-07 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 13:45 [PATCH] btrfs: scrub: set error stats when tree block spanning stripes Zhao Lei
2015-08-26 17:19 ` David Sterba
2015-08-27  1:44   ` Zhao Lei
2015-09-03 13:17     ` David Sterba
2015-09-04  3:21       ` Qu Wenruo
2015-09-07 12:37         ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150907123744.GU11834@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    --cc=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.