All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: phil@nwl.cc
Cc: netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [net-next PATCH v2] net: ipv6: use common fib_default_rule_pref
Date: Tue, 08 Sep 2015 22:38:09 -0700 (PDT)	[thread overview]
Message-ID: <20150908.223809.1598957585735076244.davem@davemloft.net> (raw)
In-Reply-To: <20150908.223705.1178974104676916256.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 08 Sep 2015 22:37:05 -0700 (PDT)

> Applied, thanks.

Actually, reverted, this doesn't even compile.

net/core/fib_rules.c:47:12: error: static declaration of ‘fib_default_rule_pref’ follows non-static declaration
 static u32 fib_default_rule_pref(struct fib_rules_ops *ops)
            ^
In file included from net/core/fib_rules.c:18:0:
include/net/fib_rules.h:120:5: note: previous declaration of ‘fib_default_rule_pref’ was here
 u32 fib_default_rule_pref(struct fib_rules_ops *ops);
     ^

  reply	other threads:[~2015-09-09  5:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 13:03 [net-next PATCH] net: ipv6: use common fib_default_rule_pref Phil Sutter
2015-09-02 18:34 ` David Miller
2015-09-02 18:46   ` Thomas Graf
2015-09-03 11:10 ` [net-next PATCH] net: kill default_pref field of struct fib_rules_ops Phil Sutter
2015-09-06  5:00   ` David Miller
2015-09-06  9:54     ` Phil Sutter
2015-09-06 10:20     ` [net-next PATCH v2] net: ipv6: use common fib_default_rule_pref Phil Sutter
2015-09-09  5:37       ` David Miller
2015-09-09  5:38         ` David Miller [this message]
2015-09-09 11:45           ` Phil Sutter
2015-09-09 12:20             ` [net-next PATCH v3] " Phil Sutter
2015-09-09 21:22               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150908.223809.1598957585735076244.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.