All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com,
	imammedo@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH v4 02/11] exec: Do vmstate unregistration from cpu_exec_exit()
Date: Wed, 9 Sep 2015 11:26:21 +0530	[thread overview]
Message-ID: <20150909055620.GE17433@in.ibm.com> (raw)
In-Reply-To: <20150904060343.GW6537@voom.redhat.com>

On Fri, Sep 04, 2015 at 04:03:43PM +1000, David Gibson wrote:
> On Thu, Aug 06, 2015 at 10:57:08AM +0530, Bharata B Rao wrote:
> > cpu_exec_init() does vmstate_register and register_savevm for the CPU device.
> > These need to be undone from cpu_exec_exit(). These changes are needed to
> > support CPU hot removal and also to correctly fail hotplug attempts
> > beyond max_cpus.
> > 
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> 
> As with 1/2, looks reasonable, but I'm wondering how x86 hotplug is
> getting away without this.

x86 does this explicitly in CPU's unrealizefn. Since registration is
done from cpu_exec_init(), I though un-registration could be done
in cpu_exec_init() instead of each arch doing it separately.

As said earlier, I will probably pursue these changes separately from
this series.

Regards,
Bharata.

  reply	other threads:[~2015-09-09  5:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06  5:27 [Qemu-devel] [RFC PATCH v4 00/11] sPAPR CPU hotplug Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit() Bharata B Rao
2015-09-04  5:31   ` David Gibson
2015-09-09  5:52     ` Bharata B Rao
2015-09-09  7:41       ` Zhu Guihua
2015-09-09  7:56         ` Bharata B Rao
2015-11-12  9:11           ` Zhu Guihua
2015-11-12  9:30             ` Bharata B Rao
2015-11-12  9:41               ` Zhu Guihua
2015-11-12  9:56               ` Andreas Färber
2015-11-12 11:40                 ` Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 02/11] exec: Do vmstate unregistration from cpu_exec_exit() Bharata B Rao
2015-09-04  6:03   ` David Gibson
2015-09-09  5:56     ` Bharata B Rao [this message]
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 03/11] cpus: Reclaim vCPU objects Bharata B Rao
2015-09-04  6:09   ` David Gibson
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 04/11] cpus: Add a sync version of cpu_remove() Bharata B Rao
2015-09-04  6:11   ` David Gibson
2015-09-09  5:57     ` Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 05/11] xics_kvm: Add cpu_destroy method to XICS Bharata B Rao
2015-08-07 11:33   ` Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 06/11] spapr: Create pseries-2.5 machine Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 07/11] spapr: Enable CPU hotplug for pseries-2.5 and add CPU DRC DT entries Bharata B Rao
2015-09-04  6:28   ` David Gibson
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 08/11] spapr: CPU hotplug support Bharata B Rao
2015-09-04  6:58   ` David Gibson
2015-09-09  6:52     ` Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 09/11] spapr: Support topologies with unfilled cores Bharata B Rao
2015-09-04  7:01   ` David Gibson
2015-09-04  8:44     ` Thomas Huth
2015-09-09  6:58       ` Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 10/11] spapr: CPU hot unplug support Bharata B Rao
2015-08-06  5:27 ` [Qemu-devel] [RFC PATCH v4 11/11] target-ppc: Enable CPU hotplug for POWER8 CPU family Bharata B Rao
2015-08-06  8:42 ` [Qemu-devel] [RFC PATCH v4 00/11] sPAPR CPU hotplug Zhu Guihua
2015-08-10  3:31   ` Bharata B Rao
2015-08-12  2:56 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150909055620.GE17433@in.ibm.com \
    --to=bharata@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=imammedo@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.