From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbbIWIjU (ORCPT ); Wed, 23 Sep 2015 04:39:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35652 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbbIWIjQ (ORCPT ); Wed, 23 Sep 2015 04:39:16 -0400 Date: Wed, 23 Sep 2015 10:39:06 +0200 From: Jiri Olsa To: Matt Fleming Cc: Vinson Lee , rostedt@goodmis.org, Jiri Olsa , raphael.beamonte@gmail.com, "H. Peter Anvin" , LKML , Arnaldo Carvalho de Melo , Peter Zijlstra , David Ahern , Ingo Molnar , Thomas Gleixner , Namhyung Kim , linux-tip-commits@vger.kernel.org, Michael Petlan Subject: Re: [tip:perf/core] tools lib api fs: Remove debugfs, tracefs and findfs objects Message-ID: <20150923083906.GB2024@krava.redhat.com> References: <1441180605-24737-15-git-send-email-jolsa@kernel.org> <20150923082302.GA2867@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150923082302.GA2867@codeblueprint.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2015 at 09:23:02AM +0100, Matt Fleming wrote: > On Mon, 21 Sep, at 05:20:03PM, Vinson Lee wrote: > > On Mon, Sep 14, 2015 at 11:59 PM, tip-bot for Jiri Olsa > > wrote: > > > Commit-ID: 60a1133a5b39738671eff1e4d77bedc1ee3fa528 > > > Gitweb: http://git.kernel.org/tip/60a1133a5b39738671eff1e4d77bedc1ee3fa528 > > > Author: Jiri Olsa > > > AuthorDate: Wed, 2 Sep 2015 09:56:44 +0200 > > > Committer: Arnaldo Carvalho de Melo > > > CommitDate: Mon, 14 Sep 2015 12:50:15 -0300 > > > > > > tools lib api fs: Remove debugfs, tracefs and findfs objects > > > > > > We have all the functionality in fs.c, let's remove unneeded > > > objects. > > > > > > Signed-off-by: Jiri Olsa > > > Cc: David Ahern > > > Cc: Matt Fleming > > > Cc: Namhyung Kim > > > Cc: Peter Zijlstra > > > Cc: Raphael Beamonte > > > Cc: Steven Rostedt > > > Link: http://lkml.kernel.org/r/1441180605-24737-15-git-send-email-jolsa@kernel.org > > > Signed-off-by: Arnaldo Carvalho de Melo > > > > Hi. > > > > This commit seems to have introduced a build failure with tools/vm. > > > > $ make -C tools vm > > [...] > > gcc -Wall -Wextra -I../lib/ -o page-types page-types.c ../lib/api/libapi.a > > page-types.c:45:28: fatal error: api/fs/debugfs.h: No such file or directory > > #include > > Given the ferocious pace of development of tools/perf, is there not > some kind of automated build that happens when new patches are picked > up, before they're pushed out? > > Things are refactored and changed so fast in this area (I dare say > faster than almost any other part of the kernel source tree) that not > having the safety net of automated builds just seems suicidal. > > And that doesn't even begin to cover runtime testing, since I've > noticed things breaking in tools/perf and people not catching it > immediately. > > Does automated testing exist for perf tools development? heh, we've been playing game "who first mention it in public will implement it" ... you won! ;-) AFAIK we have: - 'perf test' for perf specific functionality - 'make -f tests/make' for building - build framework tests I 'try' to run those before sending anything out, but we dont have automated thing that would run it any time Arnaldo push new perf/core. The RedHat QE has some more perf tool tests. There was some movement to make those public, but not sure how it ended up.. ccing Michael Petlan for news on this ;-) jirka