All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Bart van Assche <bart.vanassche@sandisk.com>,
	Ewan Milne <emilne@redhat.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Hannes Reinecke <hare@suse.de>
Subject: [PATCH] scsi: fix ifnullfree.cocci warnings
Date: Tue, 29 Sep 2015 21:40:46 +0800	[thread overview]
Message-ID: <20150929134046.GA121145@lkp-ib04> (raw)
In-Reply-To: <1443523658-87622-32-git-send-email-hare@suse.de>

drivers/scsi/scsi.c:888:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Hannes Reinecke <hare@suse.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 scsi.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -884,8 +884,7 @@ retry_pg83:
 		rcu_assign_pointer(sdev->vpd_pg83, vpd_buf);
 		mutex_unlock(&sdev->inquiry_mutex);
 		synchronize_rcu();
-		if (orig_vpd_buf)
-			kfree(orig_vpd_buf);
+		kfree(orig_vpd_buf);
 	}
 }
 

  parent reply	other threads:[~2015-09-29 13:41 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 10:47 [PATCHv5 00/36] asynchronous ALUA device handler Hannes Reinecke
2015-09-29 10:47 ` [PATCH 01/36] scsi_dh: move 'dh_state' sysfs attribute to generic code Hannes Reinecke
2015-10-01 23:18   ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 02/36] scsi: ignore errors from scsi_dh_add_device() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 03/36] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-09-29 10:47 ` [PATCH 04/36] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-09-29 10:47 ` [PATCH 05/36] scsi_dh_alua: improved logging Hannes Reinecke
2015-09-29 10:47 ` [PATCH 06/36] scsi_dh_alua: sanitze sense code handling Hannes Reinecke
2015-10-01 23:39   ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 07/36] scsi_dh_alua: use standard logging functions Hannes Reinecke
2015-10-01 23:50   ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 08/36] scsi_dh_alua: return standard SCSI return codes in submit_rtpg Hannes Reinecke
2015-10-01 23:58   ` Bart Van Assche
2015-10-02  6:03     ` Hannes Reinecke
2015-09-29 10:47 ` [PATCH 09/36] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 10/36] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 11/36] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-09-29 10:47 ` [PATCH 12/36] scsi_dh_alua: use unaligned access macros Hannes Reinecke
2015-10-02  0:01   ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 13/36] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2015-09-29 10:47 ` [PATCH 14/36] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2015-10-02  0:07   ` Bart Van Assche
2015-10-02  6:06     ` Hannes Reinecke
2015-10-02 15:03       ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 15/36] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2015-10-02 17:33   ` Bart Van Assche
2015-10-07 20:48     ` Hannes Reinecke
2015-09-29 10:47 ` [PATCH 16/36] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2015-10-02 17:14   ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 17/36] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 18/36] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode Hannes Reinecke
2015-09-29 10:47 ` [PATCH 19/36] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2015-09-29 10:47 ` [PATCH 20/36] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2015-09-29 10:47 ` [PATCH 21/36] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-09-29 10:47 ` [PATCH 22/36] scsi: Add scsi_vpd_lun_id() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 23/36] scsi_dh_alua: use unique device id Hannes Reinecke
2015-09-29 10:47 ` [PATCH 24/36] scsi: Add scsi_vpd_tpg_id() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 25/36] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 26/36] revert "scsi_dh_alua: ALUA hander attach should succeed while TPG is transitioning" Hannes Reinecke
2015-09-29 10:47 ` [PATCH 27/36] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2015-09-29 13:27   ` kbuild test robot
2015-10-01 23:34   ` Bart Van Assche
2015-10-02  5:59     ` Hannes Reinecke
2015-09-29 10:47 ` [PATCH 28/36] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2015-09-29 10:47 ` [PATCH 29/36] scsi_dh_alua: update all port states Hannes Reinecke
2015-09-29 10:47 ` [PATCH 30/36] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2015-09-29 10:47 ` [PATCH 31/36] scsi: rescan VPD attributes Hannes Reinecke
2015-09-29 13:38   ` kbuild test robot
2015-09-29 13:40   ` kbuild test robot [this message]
2015-09-29 13:40   ` kbuild test robot
2015-09-29 10:47 ` [PATCH 32/36] scsi_dh: add 'rescan' callback Hannes Reinecke
2015-09-29 10:47 ` [PATCH 33/36] scsi: Add 'access_state' attribute Hannes Reinecke
2015-09-29 13:51   ` kbuild test robot
2015-10-01 23:04   ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 34/36] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2015-09-29 10:47 ` [PATCH 35/36] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2015-09-29 10:47 ` [PATCH 36/36] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2015-09-29 18:29 ` [PATCHv5 00/36] asynchronous ALUA device handler Bart Van Assche
2015-09-30 13:21   ` Hannes Reinecke
2015-09-30 21:32     ` Bart Van Assche
2015-10-13  9:44       ` Hannes Reinecke
2015-10-13 15:07         ` Bart Van Assche
2015-10-13 15:13           ` Hannes Reinecke
2015-10-13 15:40             ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929134046.GA121145@lkp-ib04 \
    --to=lkp@intel.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=kbuild-all@01.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --subject='Re: [PATCH] scsi: fix ifnullfree.cocci warnings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.