From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753115AbbI3C5J (ORCPT ); Tue, 29 Sep 2015 22:57:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35308 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbbI3C5F (ORCPT ); Tue, 29 Sep 2015 22:57:05 -0400 Date: Wed, 30 Sep 2015 04:57:02 +0200 From: Greg KH To: Arjun Krishna Babu Cc: forest@alittletooquiet.net, tvboxspy@gmail.com, himani93@gmail.com, dilekuzulmez@gmail.com, sakshi.april5@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6655: Fixed two lines over 80 characters Message-ID: <20150930025702.GA26143@kroah.com> References: <1443546444-5724-1-git-send-email-arjunkrishnababu96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443546444-5724-1-git-send-email-arjunkrishnababu96@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 10:37:24PM +0530, Arjun Krishna Babu wrote: > Two lines of code that were over 80 characters long is fixed by > splitting them into multiple lines. > > This way, the lines of code are now easier to read. > > Issue found by checkpatch. > > Signed-off-by: Arjun Krishna Babu > --- > drivers/staging/vt6655/baseband.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > index 9e61f2d..3639f9d 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -2089,9 +2089,18 @@ bool BBbVT3253Init(struct vnt_private *priv) > byVT3253B0_UW2451[ii][0], > byVT3253B0_UW2451[ii][1]); > > - /* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ > + /* Init ANT B select, > + * TX Config CR09 = 0x61->0x45, > + * 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) > + */ > + > /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/ > - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ > + > + /* Init ANT B select, > + * RX Config CR10 = 0x28->0x2A, > + * 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) > + */ > + Please always run your patches through checkpatch.pl, so that you don't get an email from the maintainers saying that you need to run your patch through checkpatch.pl. thanks, greg k-h