From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755566AbbI3Kpa (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Sep 2015 06:45:30 -0400
Received: from mail-wi0-f176.google.com ([209.85.212.176]:33132 "EHLO
	mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755407AbbI3KpX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Sep 2015 06:45:23 -0400
Date: Wed, 30 Sep 2015 12:45:20 +0200
From: Jiri Pirko <jiri@resnulli.us>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@savoirfairelinux.com, "David S. Miller" <davem@davemloft.net>,
        Scott Feldman <sfeldma@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 0/6] net: switchdev: use specific
 switchdev_obj_*
Message-ID: <20150930104520.GE2098@nanopsycho.orion>
References: <1443542838-19234-1-git-send-email-vivien.didelot@savoirfairelinux.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443542838-19234-1-git-send-email-vivien.didelot@savoirfairelinux.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Tue, Sep 29, 2015 at 06:07:12PM CEST, vivien.didelot@savoirfairelinux.com wrote:
>This patchset changes switchdev add, del, dump operations from this:
>
>    int     (*switchdev_port_obj_add)(struct net_device *dev,
>                                      struct switchdev_obj *obj,
>                                      struct switchdev_trans *trans);
>    int     (*switchdev_port_obj_del)(struct net_device *dev,
>                                      struct switchdev_obj *obj);
>    int     (*switchdev_port_obj_dump)(struct net_device *dev,
>                                      struct switchdev_obj *obj);
>
>to something similar to the notifier_call callback of a notifier_block:
>
>    int     (*switchdev_port_obj_add)(struct net_device *dev,
>                                      enum switchdev_obj_id id,
>                                      const void *obj,
>                                      struct switchdev_trans *trans);                                                             
>    int     (*switchdev_port_obj_del)(struct net_device *dev,
>                                      enum switchdev_obj_id id,
>                                      const void *obj);
>    int     (*switchdev_port_obj_dump)(struct net_device *dev,
>                                       enum switchdev_obj_id id, void *obj,
>                                       int (*cb)(void *obj));
>
>This allows the caller to pass and expect back a specific switchdev_obj_*
>structure (e.g. switchdev_obj_fdb) instead of the generic switchdev_obj one.
>
>This will simplify pushing the callback function down to the drivers.
>
>The first 3 patches get rid of the dev parameter of the dump callback, since it
>is not always neeeded (e.g. vlan_dump) and some drivers (such as DSA drivers)
>may not have easy access to it.
>
>Patches 4 and 5 implement the change in the switchdev operations and its users.
>
>Patch 6 extracts the inner switchdev_obj_* structures from switchdev_obj and
>removes this last one.


How about attrs? We should keep objs and attrs api consistent.