From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752634AbbJEMvn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Oct 2015 08:51:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45334 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751359AbbJEMvm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Oct 2015 08:51:42 -0400
Date: Mon, 5 Oct 2015 14:51:37 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [RFC/PATCH 01/38] perf tools: Use a software dummy event to
 track task/mmap events
Message-ID: <20151005125137.GA26800@krava.landal.opennet>
References: <1443763159-29098-1-git-send-email-namhyung@kernel.org>
 <1443763159-29098-2-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443763159-29098-2-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 02, 2015 at 02:18:42PM +0900, Namhyung Kim wrote:

SNIP

>  
> +/**
> + * perf_evsel__is_dummy_tracking - Return whether given evsel is a dummy
> + * event for tracking meta events only
> + *
> + * @evsel - evsel selector to be tested
> + *
> + * Return %true if event is a dummy tracking event
> + */
> +static inline bool perf_evsel__is_dummy_tracking(struct perf_evsel *evsel)
> +{
> +	return evsel->attr.type == PERF_TYPE_SOFTWARE &&
> +		evsel->attr.config == PERF_COUNT_SW_DUMMY &&
> +		evsel->attr.task == 1 && evsel->attr.mmap == 1;

should this use now check for evsel->tracking ?

jirka