From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752175AbbJGMKZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Oct 2015 08:10:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47743 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751054AbbJGMKW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Oct 2015 08:10:22 -0400
Date: Wed, 7 Oct 2015 14:10:18 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [RFC/PATCH 09/38] perf record: Add --index option for building
 index table
Message-ID: <20151007121018.GA28390@krava.landal.opennet>
References: <1443763159-29098-1-git-send-email-namhyung@kernel.org>
 <1443763159-29098-10-git-send-email-namhyung@kernel.org>
 <20151005134641.GC26800@krava.landal.opennet>
 <CAM9d7cg-UAez_KowSSdKF2aND8v_U-7jFPxz7XFYPnWj=98yAw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7cg-UAez_KowSSdKF2aND8v_U-7jFPxz7XFYPnWj=98yAw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 07, 2015 at 05:21:46PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Mon, Oct 5, 2015 at 10:46 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Fri, Oct 02, 2015 at 02:18:50PM +0900, Namhyung Kim wrote:
> >
> > SNIP
> >
> >> +static int record__merge_index_files(struct record *rec, int nr_index)
> >> +{
> >> +     int i;
> >> +     int ret = -ENOMEM;
> >> +     u64 offset;
> >> +     char path[PATH_MAX];
> >> +     struct perf_file_section *idx;
> >> +     struct perf_data_file *file = &rec->file;
> >> +     struct perf_session *session = rec->session;
> >> +     int output_fd = perf_data_file__fd(file);
> >> +
> >> +     /* +1 for header file itself */
> >> +     nr_index++;
> >> +
> >> +     idx = calloc(nr_index, sizeof(*idx));
> >> +     if (idx == NULL)
> >> +             goto out_close;
> >> +
> >> +     offset = lseek(output_fd, 0, SEEK_END);
> >> +
> >> +     idx[0].offset = session->header.data_offset;
> >> +     idx[0].size   = offset - idx[0].offset;
> >> +
> >> +     for (i = 1; i < nr_index; i++) {
> >> +             struct stat stbuf;
> >> +             int fd = rec->fds[i - 1];
> >> +
> >> +             ret = fstat(fd, &stbuf);
> >> +             if (ret < 0)
> >> +                     goto out_close;
> >> +
> >> +             idx[i].offset = offset;
> >> +             idx[i].size   = stbuf.st_size;
> >> +
> >> +             offset += stbuf.st_size;
> >> +
> >> +             if (idx[i].size == 0)
> >> +                     continue;
> >> +
> >> +             ret = copyfile_offset(fd, 0, output_fd, idx[i].offset,
> >> +                                   idx[i].size);
> >> +             if (ret < 0)
> >> +                     goto out_close;
> >> +     }
> >> +
> >> +     session->header.index = idx;
> >> +     session->header.nr_index = nr_index;
> >> +
> >> +     perf_has_index = true;
> >
> > I might have asked earlier, but why is this global? seems like
> > perf_session member to me..
> 
> Yes you did. :-)
> 
> https://lkml.org/lkml/2015/5/19/110

ah right ;-) ok

thanks,
jirka