From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fieldses.org ([173.255.197.46]:44855 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933472AbbJIRp5 (ORCPT ); Fri, 9 Oct 2015 13:45:57 -0400 Date: Fri, 9 Oct 2015 13:45:56 -0400 From: "J. Bruce Fields" To: Christoph Hellwig Cc: linux-nfs@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] nfsd/blocklayout: accept any minlength Message-ID: <20151009174556.GA8188@fieldses.org> References: <1444395806-32111-1-git-send-email-hch@lst.de> <20151009152803.GC6825@fieldses.org> <20151009170400.GA7482@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151009170400.GA7482@lst.de> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Oct 09, 2015 at 07:04:00PM +0200, Christoph Hellwig wrote: > On Fri, Oct 09, 2015 at 11:28:03AM -0400, J. Bruce Fields wrote: > > OK, planning to apply for 4.3 just on the assumption that you know what > > you're doing, but: I don't get it--it looks like the worst that can > > happen here is we just reuturn LAYOUTUNAVAILABLE to LAYOUTGET. > > Shouldn't the client then just fall back on normal NFS IO? Why the > > hang? > > I've just retested with Trond's latest tree and can't reproduce the > hang anymore. It used to fence the client due to a lack of response, > but that might have been a different client bug that has now been fixed. OK, makes sense. This still looks like a harmless enough change, but is it still stable and 4.3 material? If it affected a released client then it's probably worth it even if it's really a client bug. If it's just something you saw once against an -rc1, I'd rather leave it for 4.4. --b.