From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751755AbbJJJHm (ORCPT <rfc822;w@1wt.eu>);
	Sat, 10 Oct 2015 05:07:42 -0400
Received: from mail-wi0-f182.google.com ([209.85.212.182]:37060 "EHLO
	mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751343AbbJJJHh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 10 Oct 2015 05:07:37 -0400
Date: Sat, 10 Oct 2015 11:07:33 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        Chandler Carruth <chandlerc@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 13/16] perf callchain: Switch default to
 'graph,0.5,caller'
Message-ID: <20151010090733.GA21078@gmail.com>
References: <1444079018-31421-1-git-send-email-acme@kernel.org>
 <1444079018-31421-14-git-send-email-acme@kernel.org>
 <CAE40pdfrVsENQeGWqDHS0HP_6S4BBNtp7cYVgjOw2zUNL--1EQ@mail.gmail.com>
 <20151009215626.GM14409@kernel.org>
 <CAE40pddVCjHVC4nD=xBcMmE6dy+xPe2rVgK8a1QM9sv0zZWEgw@mail.gmail.com>
 <20151010070906.GA1336@gmail.com>
 <CAE40pdcX2prgwkkTE2UWEghCesu9+_AtTNp+xOTCTxxUM_JU_w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE40pdcX2prgwkkTE2UWEghCesu9+_AtTNp+xOTCTxxUM_JU_w@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Brendan Gregg <brendan.d.gregg@gmail.com> wrote:

> On Sat, Oct 10, 2015 at 12:09 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Brendan Gregg <brendan.d.gregg@gmail.com> wrote:
> >
> >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo
> >> <arnaldo.melo@gmail.com> wrote:
> >> >
> >> > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu:
> >> > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo
> >> > > <acme@kernel.org> wrote:
> >> > > >
> >> > > > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >> > > >
> >> > > > Which is the most common default found in other similar tools.
> >> > >
> >> > > Interactive tools, sure, like the perf report TUI.
> >> >
> >> > > But this also changes the ordering of the non-interactive tools which
> >> > > dump stacks: "perf report -n --stdio" and "perf script". The most
> >> > > common default for dumping stacks is caller. Eg:
> >> >
> >> > And you use that for scripting?
> >>
> >> Yes; how I typically CPU profile:
> >>
> >> git clone https://github.com/brendangregg/FlameGraph
> >> cd FlameGraph
> >> perf record -F 99 -a -g -- sleep 60
> >> perf script | ./stackcollapse-perf.pl | /flamegraph.pl > flame.svg
> >>
> >> Then open flame.svg in a browser and click around. Try it. :)
> >
> > So I tried it:
> >
> >  triton:~/s/FlameGraph> ls -l flame.svg
> >  -rw-rw-r-- 1 mingo mingo 1022870 Oct 10 09:06 flame.svg
> >
> > but when I tried to view it via ImageMagick, it first showed an empty screen:
> >
> >  triton:~/s/FlameGraph> display flame.svg
> >
> > then when exiting it said:
> >
> >  display: non-conforming drawing primitive definition `text-anchor' @ error/draw.c/DrawImage/3182.
> >
> > although I guess that latter is an unrealted ImageMagick problem, not caused by
> > the SVG.
> >
> 
> Sorry, I should have said to open it in a browser (Chrome/Firefox);
> the SVG contains some (entirely embedded) JavaScript to provide
> interactivity (click to zoom, Ctrl-F to search).

aw, very nice output!

Thanks,

	Ingo