From: Christoph Hellwig <hch@lst.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Christoph Hellwig <hch@lst.de>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Stable Tree Mailing List <stable@vger.kernel.org>
Subject: Re: [PATCH] nfsd/blocklayout: accept any minlength
Date: Sun, 11 Oct 2015 15:08:22 +0200 [thread overview]
Message-ID: <20151011130821.GC3726@lst.de> (raw)
In-Reply-To: <20151009200438.GB8188@fieldses.org>
On Fri, Oct 09, 2015 at 04:04:38PM -0400, J. Bruce Fields wrote:
> I had some ideas that layouts were something a server could decline just
> on random whim. Rereading that section.... OK, looks like I was
> confused, TRYLATER is the closest we come to random whim.
>
> So the following condition on the alignments of the offset also looks
> wrong. Christoph, should it be rounding the offset down instead of
> rejecting in that case?
RFC5663 is very explicit about the extents being aligned, but doesn't
say anything about LAYOUTGET requests. It's a bit of a gray area, but
I think not handing out a layout is still the best thing to do as a client
has to be really confused to ask for an unaligned layout and expect to get
an aligned extent back. I just need to check for the best possible error
value.
> And other layoutunavailable cases might need review too.
Will do.
next prev parent reply other threads:[~2015-10-11 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 13:03 [PATCH] nfsd/blocklayout: accept any minlength Christoph Hellwig
2015-10-09 15:28 ` J. Bruce Fields
2015-10-09 17:04 ` Christoph Hellwig
2015-10-09 17:45 ` J. Bruce Fields
2015-10-09 17:54 ` Trond Myklebust
2015-10-09 20:04 ` J. Bruce Fields
2015-10-09 20:14 ` J. Bruce Fields
2015-10-11 13:08 ` Christoph Hellwig [this message]
2015-10-12 20:18 ` J. Bruce Fields
2015-10-11 13:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151011130821.GC3726@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.