From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbbJLHuG (ORCPT ); Mon, 12 Oct 2015 03:50:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:32792 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751529AbbJLHuD (ORCPT ); Mon, 12 Oct 2015 03:50:03 -0400 Date: Mon, 12 Oct 2015 09:50:01 +0200 From: Alexandre Belloni To: Sylvain Rochet Cc: Guenter Roeck , Boris BREZILLON , linux-kernel@vger.kernel.org, Nicolas Ferre , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, Wenyou Yang , Wim Van Sebroeck Subject: Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Message-ID: <20151012075001.GB3558@piout.net> References: <1444340074-15437-1-git-send-email-sylvain.rochet@finsecur.com> <1444340074-15437-7-git-send-email-sylvain.rochet@finsecur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444340074-15437-7-git-send-email-sylvain.rochet@finsecur.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylvain, The rest of the series looks good to me, one comment below: On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > watchdog_init_timeout function doesn't try to get the "timeout-sec" DT > property if timeout_parm is not zero. This change makes this DT property > working for the sama5d4 watchdog driver. > While I'm not sure of the feasibility, I think that the module parameter should override the DT property. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Mon, 12 Oct 2015 09:50:01 +0200 Subject: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first In-Reply-To: <1444340074-15437-7-git-send-email-sylvain.rochet@finsecur.com> References: <1444340074-15437-1-git-send-email-sylvain.rochet@finsecur.com> <1444340074-15437-7-git-send-email-sylvain.rochet@finsecur.com> Message-ID: <20151012075001.GB3558@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sylvain, The rest of the series looks good to me, one comment below: On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > watchdog_init_timeout function doesn't try to get the "timeout-sec" DT > property if timeout_parm is not zero. This change makes this DT property > working for the sama5d4 watchdog driver. > While I'm not sure of the feasibility, I think that the module parameter should override the DT property. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com