All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Cristina Moraru <cristina.moraru09@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192u: Add paranthesis to complex macro
Date: Mon, 12 Oct 2015 15:32:51 +0530	[thread overview]
Message-ID: <20151012100251.GC13596@sudip-pc> (raw)
In-Reply-To: <alpine.DEB.2.02.1510102131170.2053@localhost6.localdomain6>

On Sat, Oct 10, 2015 at 09:32:22PM +0200, Julia Lawall wrote:
> On Sat, 10 Oct 2015, Cristina Moraru wrote:
> 
> > Fix 'Macros with complex values should be enclosed in parentheses'
> > checkpatch warning
> > 
> > Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> > ---
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> > index c639aac..2c0060c 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> > @@ -1513,7 +1513,7 @@ static int ieee80211_parse_qos_info_param_IE(struct ieee80211_info_element
> >  }
> >  
> >  #ifdef CONFIG_IEEE80211_DEBUG
> > -#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x
> > +#define MFIE_STRING(x) (case MFIE_TYPE_ ##x: return #x)
> 
> This will not work.  One can't put parentheses around statements.  Did the 
> code compile?  Perhaps the macro is never used?  Or probably 
> CONFIG_IEEE80211_DEBUG was not turned on.

This breaks the build.

regards
sudip


      reply	other threads:[~2015-10-12 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10 19:27 [PATCH 0/6] staging: rtl8192: Fix coding style problems Cristina Moraru
2015-10-10 19:27 ` [PATCH 1/6] staging: rtl8192u: Fix spacing errors Cristina Moraru
2015-10-10 19:37   ` [Outreachy kernel] " Julia Lawall
2015-10-12  9:54   ` Sudip Mukherjee
2015-10-10 19:27 ` [PATCH 2/6] staging: rtl8192u: Move open brace to previous line Cristina Moraru
2015-10-10 19:27 ` [PATCH 3/6] staging: rtl8192u: Move else " Cristina Moraru
2015-10-10 19:27 ` [PATCH 4/6] staging: rtl8192u: Remove unnecessary braces Cristina Moraru
2015-10-10 19:35   ` [Outreachy kernel] " Julia Lawall
2015-10-10 19:27 ` [PATCH 5/6] staging: rtl8192u: Add blank line after declarations Cristina Moraru
2015-10-10 19:27 ` [PATCH 6/6] staging: rtl8192u: Add paranthesis to complex macro Cristina Moraru
2015-10-10 19:32   ` [Outreachy kernel] " Julia Lawall
2015-10-12 10:02     ` Sudip Mukherjee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012100251.GC13596@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=cristina.moraru09@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.