From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Convert WARNs during userptr revoke to SIGBUS Date: Mon, 12 Oct 2015 11:10:11 +0100 Message-ID: <20151012101011.GB27629@nuc-i3427.alporthouse.com> References: <20150928141457.GY3383@phenom.ffwll.local> <56163B4B.6010604@linux.intel.com> <20151009074801.GE18060@phenom.ffwll.local> <20151009084053.GF27939@nuc-i3427.alporthouse.com> <20151009085526.GO26718@phenom.ffwll.local> <561782D2.2070408@linux.intel.com> <20151009171402.GQ26718@phenom.ffwll.local> <20151009172615.GG7517@nuc-i3427.alporthouse.com> <561B780F.4030904@linux.intel.com> <20151012093135.GA27629@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id DEEC36E2AC for ; Mon, 12 Oct 2015 03:10:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20151012093135.GA27629@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTIsIDIwMTUgYXQgMTA6MzE6MzVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFdlIGJhc2ljYWxseSBuZWVkIHRvIGNsb25lIHRoZSBvYmosIG1vdmUgdGhlIHBhZ2Vz IGFuZCB2bWEgb3ZlciBhbmQgc28KPiBhcyB0aGUgdm1hIGRpZSB0aGUgcGFnZXMgYXJlIHVucmVm ZXJlbmNlZC4gQWxsIG5ldyB1c2Ugd2lsbCBiZSBmb3JjZWQgdG8KPiBjYWxsIGd1cCBhbmQgYmUg ZmluZS4KPiAKPiBPaywgdGhhdCBzbWVsbHMgb2ssIEknbGwgc2VlIGhvdyBkb2FibGUgdGhhdCBp cy4KCkhtbS4gSWYgd2UgdGFrZSB0aGUgdm1hLWNlbnRyaWMgZHJpdmVyIGFzIGdyYW50ZWQgKGku ZS4gdXNpbmcgdGhlIHZtYSBhcyB0aGUKdG9rZW4gd2hlbiBwaW5uaW5nLCB0aGUgdm1hIGhvbGRz IGZlbmNlcyBldGMpLCB0aGUgdHJpY2t5IHBhcnQgaWYgdGhhdCB3ZQpkb24ndCBob2xkIGEgcmVm ZXJlbmNlIGZyb20gdGhlIHBpbm5lZCB2bWEgdG8gdGhlIG9iamVjdC4gcGluX2Rpc3BsYXkgdG8K dGhlIHJlc2N1ZSEKCkluaXRpYWwgc2tldGNoOgoKc3RhdGljIHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0ICpzdGVhbF9wYWdlcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQp7CiAg ICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmNsb25lOwogICAgICAgIHN0cnVjdCBp OTE1X3ZtYSAqdm1hOwogICAgICAgIGludCBpOwoKICAgICAgICBCVUdfT04ob2JqLT5zdG9sZW4p OwoKICAgICAgICBjbG9uZSA9IGk5MTVfZ2VtX29iamVjdF9hbGxvYyhvYmotPmJhc2UuZGV2KTsK ICAgICAgICBpZiAoY2xvbmUgPT0gTlVMTCkKICAgICAgICAgICAgICAgIHJldHVybiBjbG9uZTsK CiAgICAgICAgZHJtX2dlbV9wcml2YXRlX29iamVjdF9pbml0KG9iai0+YmFzZS5kZXYsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZjbG9uZS0+YmFzZSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgb2JqLT5iYXNlLnNpemUpOwogICAgICAgIGk5MTVfZ2Vt X29iamVjdF9pbml0KGNsb25lLCBvYmotPm9wcyk7CgogICAgICAgIGxpc3Rfc3BsaWNlX2luaXQo Jm9iai0+dm1hX2xpc3QsICZjbG9uZS0+dm1hX2xpc3QpOwogICAgICAgIGxpc3RfZm9yX2VhY2hf ZW50cnkodm1hLCAmY2xvbmUtPnZtYV9saXN0LCBvYmpfbGluaykKICAgICAgICAgICAgICAgIHZt YS0+b2JqID0gY2xvbmU7CgogICAgICAgIGlmIChvYmotPnBpbl9kaXNwbGF5KSB7CiAgICAgICAg ICAgICAgICBjbG9uZS0+cGluX2Rpc3BsYXkgPSBvYmotPnBpbl9kaXNwbGF5OwogICAgICAgICAg ICAgICAgd2hpbGUgKG9iai0+cGluX2Rpc3BsYXktLSkgewogICAgICAgICAgICAgICAgICAgICAg ICBkcm1fZ2VtX29iamVjdF9yZWZlcmVuY2UoJmNsb25lLT5iYXNlKTsKICAgICAgICAgICAgICAg ICAgICAgICAgZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7CiAgICAgICAg ICAgICAgICB9CiAgICAgICAgfQoKICAgICAgICBjbG9uZS0+YmluZF9jb3VudCA9IG9iai0+Ymlu ZF9jb3VudDsKICAgICAgICBvYmotPmJpbmRfY291bnQgPSAwOwogICAgICAgIC8qIHZtYV9odCAv IHZtYV9oYXNoZWQgKi8KCiAgICAgICAgZm9yIChpID0gMDsgaSA8IEk5MTVfTlVNX1JJTkdTOyBp KyspIHsKICAgICAgICAgICAgICAgIGlmIChvYmotPmxhc3RfcmVhZFtpXS5yZXF1ZXN0ID09IE5V TEwpCiAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwoKICAgICAgICAgICAgICAgIGNs b25lLT5sYXN0X3JlYWRbaV0ucmVxdWVzdCA9IG9iai0+bGFzdF9yZWFkW2ldLnJlcXVlc3Q7CiAg ICAgICAgICAgICAgICBsaXN0X3JlcGxhY2VfaW5pdCgmb2JqLT5sYXN0X3JlYWRbaV0ubGluaywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZjbG9uZS0+bGFzdF9yZWFkW2ldLmxp bmspOwogICAgICAgICAgICAgICAgY2xvbmUtPmZsYWdzIHw9IDEgPDwgKGkgKyBJOTE1X0JPX0FD VElWRV9TSElGVCk7CiAgICAgICAgfQogICAgICAgIGlmIChvYmotPmxhc3Rfd3JpdGUucmVxdWVz dCkgewogICAgICAgICAgICAgICAgY2xvbmUtPmxhc3Rfd3JpdGUucmVxdWVzdCA9IG9iai0+bGFz dF93cml0ZS5yZXF1ZXN0OwogICAgICAgICAgICAgICAgbGlzdF9yZXBsYWNlX2luaXQoJm9iai0+ bGFzdF93cml0ZS5saW5rLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmNsb25l LT5sYXN0X3dyaXRlLmxpbmspOwogICAgICAgIH0KCiAgICAgICAgY2xvbmUtPmRpcnR5ID0gb2Jq LT5kaXJ0eTsKICAgICAgICBvYmotPmRpcnR5ID0gZmFsc2U7CgogICAgICAgIGNsb25lLT50aWxp bmdfbW9kZSA9IG9iai0+dGlsaW5nX21vZGU7CiAgICAgICAgY2xvbmUtPnN0cmlkZSA9IG9iai0+ c3RyaWRlOwoKICAgICAgICBjbG9uZS0+cGluX2Rpc3BsYXkgPSBvYmotPnBpbl9kaXNwbGF5Owog ICAgICAgIG9iai0+cGluX2Rpc3BsYXkgPSAwOwoKICAgICAgICBjbG9uZS0+bWFkdiA9IEk5MTVf TUFEVl9ET05UTkVFRDsKICAgICAgICBjbG9uZS0+cGFnZXMgPSBvYmotPnBhZ2VzOwogICAgICAg IGNsb25lLT5wYWdlc19waW5fY291bnQgPSBvYmotPnBhZ2VzX3Bpbl9jb3VudDsKICAgICAgICBj bG9uZS0+Z2V0X3BhZ2UgPSBvYmotPmdldF9wYWdlOwogICAgICAgIGNsb25lLT52bWFwcGluZyA9 IG9iai0+dm1hcHBpbmc7CiAgICAgICAgb2JqLT5wYWdlcyA9IE5VTEw7CiAgICAgICAgb2JqLT5w YWdlc19waW5fY291bnQgPSAwOwogICAgICAgIG9iai0+dm1hcHBpbmcgPSBOVUxMOwoKICAgICAg ICBjbG9uZS0+Yml0XzE3ID0gb2JqLT5iaXRfMTc7CiAgICAgICAgb2JqLT5iaXRfMTcgPSBOVUxM OwoKICAgICAgICBpOTE1X2dlbV9yZWxlYXNlX21tYXAob2JqKTsKCiAgICAgICAgaWYgKEk5MTVf Qk9fSVNfQUNUSVZFKGNsb25lKSkKICAgICAgICAgICAgICAgIGNsb25lLT5hY3RpdmVfcmVmZXJl bmNlID0gdHJ1ZTsKICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICBkcm1fZ2VtX29iamVjdF91 bnJlZmVyZW5jZSgmY2xvbmUtPmJhc2UpOwoKICAgICAgICByZXR1cm4gY2xvbmU7Cn0KCkl0IGRv ZXMgaGF2ZSB0aGUgcHJlc3VtcHRpb24gdGhhdCB3ZSBoYXZlIGVpdGhlciBhbiBhY3RpdmUgcmVm ZXJlbmNlIG9yIGEKcGlubmVkIHJlZmVyZW5jZS4KLUNocmlzCgotLSAKQ2hyaXMgV2lsc29uLCBJ bnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=