From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbbJMLOS (ORCPT ); Tue, 13 Oct 2015 07:14:18 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47385 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbbJMLOQ (ORCPT ); Tue, 13 Oct 2015 07:14:16 -0400 Date: Tue, 13 Oct 2015 04:30:16 -0700 (PDT) Message-Id: <20151013.043016.167211384838385409.davem@davemloft.net> To: gerlando.falauto@keymile.com Cc: netdev@vger.kernel.org, timur@tabi.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, ogabbay@advaoptical.com, bigeasy@linutronix.de, galak@kernel.crashing.org Subject: Re: [PATCH v2 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range From: David Miller In-Reply-To: <1444634321-14902-1-git-send-email-gerlando.falauto@keymile.com> References: <1371041258-15298-1-git-send-email-ogabbay@advaoptical.com> <1444634321-14902-1-git-send-email-gerlando.falauto@keymile.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Oct 2015 04:14:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gerlando Falauto Date: Mon, 12 Oct 2015 09:18:40 +0200 > When configuring the MDIO subsystem it is also necessary to configure > the TBI register. Make sure the TBI is contained within the mapped > register range in order to: > a) make sure the address is computed correctly > b) make users aware that we're actually accessing that register > > In case of error, print a message but continue anyway. > > Signed-off-by: Gerlando Falauto > Cc: Timur Tabi > Cc: David S. Miller > Cc: Kumar Gala > --- > Changes from v1: > - Added type cast & fixed range > - removed freescale recipients Applied.