From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbbJNBO1 (ORCPT ); Tue, 13 Oct 2015 21:14:27 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:55211 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbbJNBOY (ORCPT ); Tue, 13 Oct 2015 21:14:24 -0400 Date: Tue, 13 Oct 2015 18:30:26 -0700 (PDT) Message-Id: <20151013.183026.1058494354111432068.davem@davemloft.net> To: geliangtang@163.com Cc: joe@perches.com, isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mISDN: use kstrdup() in dsp_pipeline_build From: David Miller In-Reply-To: <01134401b5d955b4dd794562d85608db4fb8ba21.1444666330.git.geliangtang@163.com> References: <1444504930.8012.19.camel@perches.com> <01134401b5d955b4dd794562d85608db4fb8ba21.1444666330.git.geliangtang@163.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Oct 2015 18:14:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geliang Tang Date: Mon, 12 Oct 2015 01:19:07 -0700 > Use kstrdup instead of strlen-kmalloc-strcpy. Remove unneeded NULL > test, it will be tested inside kstrdup. Remove 0 length string test, > it has been tested in the caller of dsp_pipeline_build. > > Signed-off-by: Geliang Tang > --- > Changes in v2: > - Remove unneeded NULL test. Applied, thanks.