From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964792AbbJMPpq (ORCPT ); Tue, 13 Oct 2015 11:45:46 -0400 Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:47488 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932737AbbJMPpn (ORCPT ); Tue, 13 Oct 2015 11:45:43 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3867:4321:5007:6261:6642:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cause30_145f34a1aa756 X-Filterd-Recvd-Size: 2535 Date: Tue, 13 Oct 2015 11:45:38 -0400 From: Steven Rostedt To: AKASHI Takahiro Cc: catalin.marinas@arm.com, will.deacon@arm.com, jungseoklee85@gmail.com, olof@lixom.net, broonie@kernel.org, david.griego@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] ftrace: allow arch-specific stack tracer Message-ID: <20151013114538.5d37ffc9@gandalf.local.home> In-Reply-To: <1444298504-10392-6-git-send-email-takahiro.akashi@linaro.org> References: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> <1444298504-10392-6-git-send-email-takahiro.akashi@linaro.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Oct 2015 19:01:42 +0900 AKASHI Takahiro wrote: > include/linux/ftrace.h | 10 ++++++++++ > kernel/trace/trace_stack.c | 22 ++++++++++++++-------- > 2 files changed, 24 insertions(+), 8 deletions(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index d77b195..e538400 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -270,7 +270,17 @@ static inline void ftrace_kill(void) { } > #define FTRACE_STACK_FRAME_OFFSET 0 > #endif > > +#define STACK_TRACE_ENTRIES 500 > + > +struct stack_trace; > + > +extern unsigned stack_dump_index[]; > +extern struct stack_trace max_stack_trace; > +extern unsigned long max_stack_size; > +extern arch_spinlock_t max_stack_lock; > + > extern int stack_tracer_enabled; > +void print_max_stack(void); OK, if we are making these external, they need to have better name space naming. stack_dump_index => stack_trace_index max_stack_trace => stack_trace_max max_stack_size => stack_trace_max_size print_max_stack() => stack_trace_print() -- Steve > int > stack_trace_sysctl(struct ctl_table *table, int write, > void __user *buffer, size_t *lenp, > diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c > index 30521ea..ff1a191 100644 > --- a/kernel/trace/trace_stack.c > +++ b/kernel/trace/trace_stack.c > @@ -16,24 +16,22 @@ > > #include "trace.h" > From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Tue, 13 Oct 2015 11:45:38 -0400 Subject: [PATCH v3 5/7] ftrace: allow arch-specific stack tracer In-Reply-To: <1444298504-10392-6-git-send-email-takahiro.akashi@linaro.org> References: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> <1444298504-10392-6-git-send-email-takahiro.akashi@linaro.org> Message-ID: <20151013114538.5d37ffc9@gandalf.local.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 8 Oct 2015 19:01:42 +0900 AKASHI Takahiro wrote: > include/linux/ftrace.h | 10 ++++++++++ > kernel/trace/trace_stack.c | 22 ++++++++++++++-------- > 2 files changed, 24 insertions(+), 8 deletions(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index d77b195..e538400 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -270,7 +270,17 @@ static inline void ftrace_kill(void) { } > #define FTRACE_STACK_FRAME_OFFSET 0 > #endif > > +#define STACK_TRACE_ENTRIES 500 > + > +struct stack_trace; > + > +extern unsigned stack_dump_index[]; > +extern struct stack_trace max_stack_trace; > +extern unsigned long max_stack_size; > +extern arch_spinlock_t max_stack_lock; > + > extern int stack_tracer_enabled; > +void print_max_stack(void); OK, if we are making these external, they need to have better name space naming. stack_dump_index => stack_trace_index max_stack_trace => stack_trace_max max_stack_size => stack_trace_max_size print_max_stack() => stack_trace_print() -- Steve > int > stack_trace_sysctl(struct ctl_table *table, int write, > void __user *buffer, size_t *lenp, > diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c > index 30521ea..ff1a191 100644 > --- a/kernel/trace/trace_stack.c > +++ b/kernel/trace/trace_stack.c > @@ -16,24 +16,22 @@ > > #include "trace.h" >