From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation Date: Tue, 13 Oct 2015 18:04:40 +0300 Message-ID: <20151013150440.GR26517@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 536BE6EB8C for ; Tue, 13 Oct 2015 08:05:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lukas Wunner Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMzAsIDIwMTUgYXQgMTA6MDY6MjdBTSArMDEwMCwgTHVrYXMgV3VubmVyIHdy b3RlOgo+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4g Cj4gV2UgaGFkIHR3byBmYWlsdXJlIG1vZGVzIGhlcmU6Cj4gCj4gMS4KPiBEZWFkbG9jayBpbiBp bnRlbGZiX2FsbG9jIGZhaWx1cmUgcGF0aCB3aGVyZSBpdCBjYWxscwo+IGRybV9mcmFtZWJ1ZmZl cl9yZW1vdmUsIHdoaWNoIGdyYWJzIHRoZSBzdHJ1Y3QgbXV0ZXggYW5kIGludGVsZmJfY3JlYXRl Cj4gKGNhbGxlciBvZiBpbnRlbGZiX2FsbG9jKSB3YXMgYWxyZWFkeSBob2xkaW5nIGl0Lgo+IAo+ IDIuCj4gRGVhZGxvY2sgaW4gaW50ZWxmYl9jcmVhdGUgZmFpbHVyZSBwYXRoIHdoZXJlIGl0IGNh bGxzCj4gZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlLCB3aGljaCBncmFicyB0aGUgc3RydWN0 IG11dGV4IGFuZAo+IGludGVsZmJfY3JlYXRlIHdhcyBhbHJlYWR5IGhvbGRpbmcgaXQuCj4gCj4g djI6Cj4gICAgKiBSZWZvcm1hdCBjb21taXQgbXNnIHRvIDcyIGNoYXJzLiAoTHVrYXMgV3VubmVy KQo+ICAgICogQWRkIHRoaXJkIGZhaWx1cmUgbW9kZS4gKEx1a2FzIFd1bm5lcikKPiAKPiB2MzoK PiAgICAqIE9uIGZiIGFsbG9jIGZhaWx1cmUsIHVucmVmIGdlbSBvYmplY3Qgd2hlcmUgaXQgZ2V0 cyByZWZlZCwKPiAgICAgIGZpeCBkb3VibGUgdW5yZWYgaW4gc2VwYXJhdGUgY29tbWl0LiAoVmls bGUgU3lyasOkbMOkKQo+IAo+IHY0Ogo+ICAgICogTG9jayBzdHJ1Y3QgbXV0ZXggb24gdW5yZWYu IChDaHJpcyBXaWxzb24pCj4gCj4gdjU6Cj4gICAgKiBSZWJhc2Ugb24gZHJtLWludGVsLW5pZ2h0 bHkgMjAxNXktMDltLTA0ZC0wOGgtMTltLTM1cyBVVEMsCj4gICAgICByZXBocmFzZSBjb21taXQg bWVzc2FnZS4gKEphbmkgTmljdWxhKQo+IAo+IFRlc3RlZC1ieTogUGllcnJlIE1vcmVhdSA8cGll cnJlLm1vcnJvd0BmcmVlLmZyPgo+ICAgICBbTUJQICA1LDMgMjAwOSAgbnZpZGlhIDk0MDBNICsg OTYwME0gR1QgICBwcmUtcmV0aW5hXQo+IFRlc3RlZC1ieTogUGF1bCBIb3JkaWllbmtvIDxwdnQu Z29yZEBnbWFpbC5jb20+Cj4gICAgIFtNQlAgIDYsMiAyMDEwICBpbnRlbCBJTEsgKyBudmlkaWEg R1QyMTYgIHByZS1yZXRpbmFdCj4gVGVzdGVkLWJ5OiBXaWxsaWFtIEJyb3duIDx3aWxsaWFtQGJs YWNraGF0cy5uZXQuYXU+Cj4gICAgIFtNQlAgIDgsMiAyMDExICBpbnRlbCBTTkIgKyBhbWQgdHVy a3MgICAgIHByZS1yZXRpbmFdCj4gVGVzdGVkLWJ5OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5l ci5kZT4KPiAgICAgW01CUCAgOSwxIDIwMTIgIGludGVsIElWQiArIG52aWRpYSBHSzEwNyAgcHJl LXJldGluYV0KPiBUZXN0ZWQtYnk6IEJydW5vIEJpZXJiYXVtZXIgPGJydW5vQGJpZXJiYXVtZXIu bmV0Pgo+ICAgICBbTUJQIDExLDMgMjAxMyAgaW50ZWwgSFNXICsgbnZpZGlhIEdLMTA3ICByZXRp bmFdCj4gCj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KPiBGaXhlczogNjBhNWNhMDE1ZmZkICgiZHJtL2k5MTU6IEFkZCBsb2NraW5nIGFy b3VuZAo+ICAgICBmcmFtZWJ1ZmZlcl9yZWZlcmVuY2VzLS0iKQo+IFJlcG9ydGVkLWJ5OiBMdWth cyBXdW5uZXIgPGx1a2FzQHd1bm5lci5kZT4KPiBbTHVrYXM6IENyZWF0ZSB2MyArIHY0ICsgdjUg YmFzZWQgb24gVHZydGtvJ3MgdjJdCj4gU2lnbmVkLW9mZi1ieTogTHVrYXMgV3VubmVyIDxsdWth c0B3dW5uZXIuZGU+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIHwgMjAgKysrKysrKysrKysrLS0tLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gaW5kZXggOTY0NzZkNy4uZWVlMzMwNiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IEBAIC0xMTksNyArMTE5LDcgQEAgc3RhdGlj IGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIHsKPiAg CXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0KPiAgCQljb250YWluZXJfb2YoaGVscGVyLCBz dHJ1Y3QgaW50ZWxfZmJkZXYsIGhlbHBlcik7Cj4gLQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm YjsKPiArCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gTlVMTDsKPiAgCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSBoZWxwZXItPmRldjsKPiAgCXN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyIG1v ZGVfY21kID0ge307Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+IEBAIC0x MzcsNiArMTM3LDggQEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVs cGVyICpoZWxwZXIsCj4gIAltb2RlX2NtZC5waXhlbF9mb3JtYXQgPSBkcm1fbW9kZV9sZWdhY3lf ZmJfZm9ybWF0KHNpemVzLT5zdXJmYWNlX2JwcCwKPiAgCQkJCQkJCSAgc2l6ZXMtPnN1cmZhY2Vf ZGVwdGgpOwo+ICAKPiArCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCj4gIAlz aXplID0gbW9kZV9jbWQucGl0Y2hlc1swXSAqIG1vZGVfY21kLmhlaWdodDsKPiAgCXNpemUgPSBQ QUdFX0FMSUdOKHNpemUpOwo+ICAJb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW4o ZGV2LCBzaXplKTsKPiBAQCAtMTU4LDE4ICsxNjAsMjEgQEAgc3RhdGljIGludCBpbnRlbGZiX2Fs bG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAlyZXQgPSBpbnRlbF9waW5fYW5k X2ZlbmNlX2ZiX29iaihOVUxMLCBmYiwgTlVMTCwgTlVMTCwgTlVMTCk7Cj4gIAlpZiAocmV0KSB7 Cj4gIAkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gcGluIG9iajogJWRcbiIsIHJldCk7Cj4gLQkJZ290 byBvdXRfZmI7Cj4gKwkJZ290byBvdXRfdW5yZWY7Cj4gIAl9Cj4gIAo+ICsJbXV0ZXhfdW5sb2Nr KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwo+ICAJaWZiZGV2LT5mYiA9IHRvX2ludGVsX2ZyYW1l YnVmZmVyKGZiKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgCj4gLW91dF9mYjoKPiAtCWRybV9mcmFt ZWJ1ZmZlcl9yZW1vdmUoZmIpOwo+ICBvdXRfdW5yZWY6Cj4gIAlkcm1fZ2VtX29iamVjdF91bnJl ZmVyZW5jZSgmb2JqLT5iYXNlKTsKCklmIGZiIGluaXQgc3VjY2VlZGVkIGl0IHRvb2sgb3ZlciB0 aGUgcmVmLCBubz8gU28gZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSgpCndpbGwgbm93IGF0dGVtcHQg dG8gdW5yZWYgb25lIHRvbyBtYW55IHRpbWVzLgoKVGhpcyB0YWtpbmcgb3ZlciByZWZzIHN0dWZm IGlzIGNvbmZ1c2luZy4gTWF5YmUgaXQgd291bGQgYmUgYmV0dGVyIGlmCmV2ZXJ5b25lIGp1c3Qg dG9vayBhbiBleHRyYSByZWYgd2hlbiB0aGV5IHN0YXNoIHRoZSBvYmogcG9pbnRlcgpzb21ld2hl cmUsIGFuZCBldmVyeW9uZSB3b3VsZCB0aGVuIGFsd2F5cyByZWxlYXNlIHdoYXRldmVyIHJlZiB0 aGV5IG93bgphbmQgbm8gbG9uZ2VyIG5lZWQuCgo+ICBvdXQ6Cj4gKwltdXRleF91bmxvY2soJmRl di0+c3RydWN0X211dGV4KTsKPiArCWlmIChmYikKPiArCQlkcm1fZnJhbWVidWZmZXJfcmVtb3Zl KGZiKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gQEAgLTE4Nyw4ICsxOTIsNiBAQCBzdGF0 aWMgaW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAlp bnQgc2l6ZSwgcmV0Owo+ICAJYm9vbCBwcmVhbGxvYyA9IGZhbHNlOwo+ICAKPiAtCW11dGV4X2xv Y2soJmRldi0+c3RydWN0X211dGV4KTsKPiAtCj4gIAlpZiAoaW50ZWxfZmIgJiYKPiAgCSAgICAo c2l6ZXMtPmZiX3dpZHRoID4gaW50ZWxfZmItPmJhc2Uud2lkdGggfHwKPiAgCSAgICAgc2l6ZXMt PmZiX2hlaWdodCA+IGludGVsX2ZiLT5iYXNlLmhlaWdodCkpIHsKPiBAQCAtMjAzLDcgKzIwNiw3 IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVhdGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBl ciwKPiAgCQlEUk1fREVCVUdfS01TKCJubyBCSU9TIGZiLCBhbGxvY2F0aW5nIGEgbmV3IG9uZVxu Iik7Cj4gIAkJcmV0ID0gaW50ZWxmYl9hbGxvYyhoZWxwZXIsIHNpemVzKTsKPiAgCQlpZiAocmV0 KQo+IC0JCQlnb3RvIG91dF91bmxvY2s7Cj4gKwkJCXJldHVybiByZXQ7Cj4gIAkJaW50ZWxfZmIg PSBpZmJkZXYtPmZiOwo+ICAJfSBlbHNlIHsKPiAgCQlEUk1fREVCVUdfS01TKCJyZS11c2luZyBC SU9TIGZiXG4iKTsKPiBAQCAtMjE1LDYgKzIxOCw4IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVh dGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCW9iaiA9IGludGVsX2ZiLT5vYmo7 Cj4gIAlzaXplID0gb2JqLT5iYXNlLnNpemU7Cj4gIAo+ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1 Y3RfbXV0ZXgpOwo+ICsKCkknbSB0aGlua2luZyB3ZSB3b24ndCBldmVuIG5lZWQgdGhlIGxvY2sg aGVyZSBhbnltb3JlLiBCdXQgbWF5YmUgSSdtCm1pc3Npbmcgc29tZXRoaW5nLgoKPiAgCWluZm8g PSBkcm1fZmJfaGVscGVyX2FsbG9jX2ZiaShoZWxwZXIpOwo+ICAJaWYgKElTX0VSUihpbmZvKSkg ewo+ICAJCXJldCA9IFBUUl9FUlIoaW5mbyk7Cj4gQEAgLTI3Niw3ICsyODEsNiBAQCBvdXRfZGVz dHJveV9mYmk6Cj4gIG91dF91bnBpbjoKPiAgCWk5MTVfZ2VtX29iamVjdF9nZ3R0X3VucGluKG9i aik7Cj4gIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKCkFuZCB0aGlz IHJlZiB3ZSBkb24ndCBvd24gZWl0aGVyIEFGQUlDUy4KCj4gLW91dF91bmxvY2s6Cj4gIAltdXRl eF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAtLSAK PiAyLjEuMAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK