From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932758AbbJMPrQ (ORCPT ); Tue, 13 Oct 2015 11:47:16 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:49887 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbbJMPnc (ORCPT ); Tue, 13 Oct 2015 11:43:32 -0400 Date: Tue, 13 Oct 2015 16:23:31 +0100 From: Charles Keepax To: Lee Jones CC: Chanwoo Choi , Mark Brown , , , , , , , , , Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection Message-ID: <20151013152331.GL8805@ck-lbox> References: <20151007100017.GB12635@sirena.org.uk> <20151007122642.GH17172@x1> <20151012084554.GB8805@ck-lbox> <20151012134309.GE1542@sirena.org.uk> <20151013080218.GV17172@x1> <20151013121450.GD8805@ck-lbox> <20151013135053.GB32409@x1> <561D0E4C.4010205@samsung.com> <561D10A6.7040504@samsung.com> <20151013141822.GC32409@x1> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151013141822.GC32409@x1> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-13_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1510130180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 03:18:22PM +0100, Lee Jones wrote: > On Tue, 13 Oct 2015, Chanwoo Choi wrote: > > On 2015년 10월 13일 22:59, Chanwoo Choi wrote: > > > On 2015년 10월 13일 22:50, Lee Jones wrote: > > >> On Tue, 13 Oct 2015, Charles Keepax wrote: > > >> > > >>> On Tue, Oct 13, 2015 at 09:02:18AM +0100, Lee Jones wrote: > > >>>> On Mon, 12 Oct 2015, Mark Brown wrote: > > >>>> > > >>>>> On Mon, Oct 12, 2015 at 09:45:54AM +0100, Charles Keepax wrote: > > >>>>>> On Wed, Oct 07, 2015 at 01:26:42PM +0100, Lee Jones wrote: > > >>>>>>> On Wed, 07 Oct 2015, Mark Brown wrote: > > >> Now I know that jack detection is an Extcon thing and Extcon Ack will > > >> do just nicely. However, that begs the question; if they are an > > >> Extcon thing, why aren't they in the Extcon binding document? > > > > > > As I knew, the arizona-extcon is one device of the MFD devices > > > for WMxxxx series in the driver/mfd/arizona-core.c. So, If arizona-extcon > > > driver needs the some property for dt support, some property should be > > > included in MFD device tree node. There is no separate device tree node for > > > arizona-extcon driver. > > > > If creating the separate extcon doc for extcon-arizona.c driver, it is possible > > to make the child device tree node which is located at the below of arizona MFD > > device tree node. > > > > I agree about Lee's opinion to make the separate the Extcon doc for extcon-arizona.c. > > This is how we normally document MFDs. Extcon doesn't even need to > have it's own child-node (it can if you want though -- it's however > you want to represent it), you can just put something like this in the > MFD binding doc: > > Optional properties > this : Does this > that : Does that > > Also any child device specific property: > GPIO See: ../extcon/arizona.txt > Extcon See: ../gpio/arizona.txt > > Etc. Or words to that effect. See some other MFDs for examples. More accident of history than anything else I will send a patch to split the binding up into the seperate subsystems shortly. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection Date: Tue, 13 Oct 2015 16:23:31 +0100 Message-ID: <20151013152331.GL8805@ck-lbox> References: <20151007100017.GB12635@sirena.org.uk> <20151007122642.GH17172@x1> <20151012084554.GB8805@ck-lbox> <20151012134309.GE1542@sirena.org.uk> <20151013080218.GV17172@x1> <20151013121450.GD8805@ck-lbox> <20151013135053.GB32409@x1> <561D0E4C.4010205@samsung.com> <561D10A6.7040504@samsung.com> <20151013141822.GC32409@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20151013141822.GC32409@x1> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: Chanwoo Choi , Mark Brown , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com List-Id: devicetree@vger.kernel.org On Tue, Oct 13, 2015 at 03:18:22PM +0100, Lee Jones wrote: > On Tue, 13 Oct 2015, Chanwoo Choi wrote: > > On 2015=EB=85=84 10=EC=9B=94 13=EC=9D=BC 22:59, Chanwoo Choi wrote: > > > On 2015=EB=85=84 10=EC=9B=94 13=EC=9D=BC 22:50, Lee Jones wrote: > > >> On Tue, 13 Oct 2015, Charles Keepax wrote: > > >> > > >>> On Tue, Oct 13, 2015 at 09:02:18AM +0100, Lee Jones wrote: > > >>>> On Mon, 12 Oct 2015, Mark Brown wrote: > > >>>> > > >>>>> On Mon, Oct 12, 2015 at 09:45:54AM +0100, Charles Keepax wrot= e: > > >>>>>> On Wed, Oct 07, 2015 at 01:26:42PM +0100, Lee Jones wrote: > > >>>>>>> On Wed, 07 Oct 2015, Mark Brown wrote: > > >> Now I know that jack detection is an Extcon thing and Extcon Ack= will > > >> do just nicely. However, that begs the question; if they are an > > >> Extcon thing, why aren't they in the Extcon binding document? > > >=20 > > > As I knew, the arizona-extcon is one device of the MFD devices=20 > > > for WMxxxx series in the driver/mfd/arizona-core.c. So, If arizon= a-extcon > > > driver needs the some property for dt support, some property shou= ld be > > > included in MFD device tree node. There is no separate device tre= e node for > > > arizona-extcon driver. > >=20 > > If creating the separate extcon doc for extcon-arizona.c driver, it= is possible > > to make the child device tree node which is located at the below of= arizona MFD > > device tree node. > >=20 > > I agree about Lee's opinion to make the separate the Extcon doc for= extcon-arizona.c. >=20 > This is how we normally document MFDs. Extcon doesn't even need to > have it's own child-node (it can if you want though -- it's however > you want to represent it), you can just put something like this in th= e > MFD binding doc: >=20 > Optional properties > this : Does this > that : Does that >=20 > Also any child device specific property: > GPIO See: ../extcon/arizona.txt > Extcon See: ../gpio/arizona.txt >=20 > Etc. Or words to that effect. See some other MFDs for examples. More accident of history than anything else I will send a patch to split the binding up into the seperate subsystems shortly. Thanks, Charles