From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v5 2/2] drm/i915: On fb alloc failure,
 unref gem object where it gets refed
Date: Tue, 13 Oct 2015 18:39:31 +0300
Message-ID: <20151013153931.GS26517@intel.com>
References: <f0cd66427039ce1bdc61460a9d833e6d858cff3e.1441363361.git.lukas@wunner.de>
 <521e48fc5fc8d211ed2847070120ff4032b7a383.1441363361.git.lukas@wunner.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 841D17211D
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 Oct 2015 08:39:35 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <521e48fc5fc8d211ed2847070120ff4032b7a383.1441363361.git.lukas@wunner.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gU2F0LCBKdWwgMDQsIDIwMTUgYXQgMTE6NTA6NThBTSArMDIwMCwgTHVrYXMgV3VubmVyIHdy
b3RlOgo+IEN1cnJlbnRseSB3aGVuIGFsbG9jYXRpbmcgYSBmcmFtZWJ1ZmZlciBmYWlscywgdGhl
IGdlbSBvYmplY3QgZ2V0cwo+IHVucmVmZWQgYXQgdGhlIGJvdHRvbSBvZiB0aGUgY2FsbCBjaGFp
biBpbiBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZSwKPiBub3Qgd2hlcmUgaXQgZ2V0cyByZWZl
ZCwgd2hpY2ggaXMgaW4gaW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlX2Zvcl9tb2RlCj4gKHZpYSBp
OTE1X2dlbV9hbGxvY19vYmplY3QpIGFuZCBpbiBpbnRlbF91c2VyX2ZyYW1lYnVmZmVyX2NyZWF0
ZQo+ICh2aWEgZHJtX2dlbV9vYmplY3RfbG9va3VwKS4KPiAKPiBUaGlzIGludml0ZXMgbWlzdGFr
ZXM6IEFzIGRpc2NvdmVyZWQgYnkgVHZydGtvIFVyc3VsaW4sIGEgZG91YmxlIHVucmVmCj4gaGFz
IHNuZWFrZWQgaW50byBpbnRlbGZiX2FsbG9jICh3aGljaCBjYWxscyBfX2ludGVsX2ZyYW1lYnVm
ZmVyX2NyZWF0ZSkuCj4gCj4gQXMgc3VnZ2VzdGVkIGJ5IFZpbGxlIFN5cmrDpGzDpCwgaW1wcm92
ZSBjb2RlIGNsYXJpdHkgYnkgbW92aW5nIHRoZSB1bnJlZgo+IGF3YXkgZnJvbSBfX2ludGVsX2Zy
YW1lYnVmZmVyX2NyZWF0ZSB0byB3aGVyZSB0aGUgZ2VtIG9iamVjdCBnZXRzIHJlZmVkLgo+IAo+
IFtDaGFuZ2Vsb2cgaXMgaW4gcHJlY2VkaW5nIHBhdGNoIGJ5IFR2cnRrbyBVcnN1bGluLl0KPiAK
PiBUZXN0ZWQtYnk6IFBpZXJyZSBNb3JlYXUgPHBpZXJyZS5tb3Jyb3dAZnJlZS5mcj4KPiAgICAg
W01CUCAgNSwzIDIwMDkgIG52aWRpYSA5NDAwTSArIDk2MDBNIEdUICAgcHJlLXJldGluYV0KPiBU
ZXN0ZWQtYnk6IFBhdWwgSG9yZGlpZW5rbyA8cHZ0LmdvcmRAZ21haWwuY29tPgo+ICAgICBbTUJQ
ICA2LDIgMjAxMCAgaW50ZWwgSUxLICsgbnZpZGlhIEdUMjE2ICBwcmUtcmV0aW5hXQo+IFRlc3Rl
ZC1ieTogV2lsbGlhbSBCcm93biA8d2lsbGlhbUBibGFja2hhdHMubmV0LmF1Pgo+ICAgICBbTUJQ
ICA4LDIgMjAxMSAgaW50ZWwgU05CICsgYW1kIHR1cmtzICAgICBwcmUtcmV0aW5hXQo+IFRlc3Rl
ZC1ieTogTHVrYXMgV3VubmVyIDxsdWthc0B3dW5uZXIuZGU+Cj4gICAgIFtNQlAgIDksMSAyMDEy
ICBpbnRlbCBJVkIgKyBudmlkaWEgR0sxMDcgIHByZS1yZXRpbmFdCj4gVGVzdGVkLWJ5OiBCcnVu
byBCaWVyYmF1bWVyIDxicnVub0BiaWVyYmF1bWVyLm5ldD4KPiAgICAgW01CUCAxMSwzIDIwMTMg
IGludGVsIEhTVyArIG52aWRpYSBHSzEwNyAgcmV0aW5hXQo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1
a2FzIFd1bm5lciA8bHVrYXNAd3VubmVyLmRlPgo+IEZpeGVzOiBhOGJiNjgxODI3MGMgKCJkcm0v
aTkxNTogRml4IGVycm9yIHBhdGggbGVhayBpbiBmYmRldiBmYgo+ICAgICBhbGxvY2F0aW9uIikK
PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRr
byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzD
pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDIxICsrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZp
bGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNDIxYWMxNS4uNjhkMDUxZCAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTAwMzMsMjAgKzEwMDMzLDE3
IEBAIF9faW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g
IAlpbnQgcmV0Owo+ICAKPiAgCWludGVsX2ZiID0ga3phbGxvYyhzaXplb2YoKmludGVsX2ZiKSwg
R0ZQX0tFUk5FTCk7Cj4gLQlpZiAoIWludGVsX2ZiKSB7Cj4gLQkJZHJtX2dlbV9vYmplY3RfdW5y
ZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4gKwlpZiAoIWludGVsX2ZiKQo+ICAJCXJldHVybiBFUlJf
UFRSKC1FTk9NRU0pOwo+IC0JfQo+ICAKPiAgCXJldCA9IGludGVsX2ZyYW1lYnVmZmVyX2luaXQo
ZGV2LCBpbnRlbF9mYiwgbW9kZV9jbWQsIG9iaik7Cj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gZXJy
Owo+ICAKPiAgCXJldHVybiAmaW50ZWxfZmItPmJhc2U7Cj4gKwo+ICBlcnI6Cj4gLQlkcm1fZ2Vt
X29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAgCWtmcmVlKGludGVsX2ZiKTsKPiAt
Cj4gIAlyZXR1cm4gRVJSX1BUUihyZXQpOwo+ICB9Cj4gIAo+IEBAIC0xMDA4Niw2ICsxMDA4Myw3
IEBAIGludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZV9mb3JfbW9kZShzdHJ1Y3QgZHJtX2RldmljZSAq
ZGV2LAo+ICAJCQkJICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAgCQkJCSAgaW50
IGRlcHRoLCBpbnQgYnBwKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYjsKPiAg
CXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gIAlzdHJ1Y3QgZHJtX21vZGVfZmJf
Y21kMiBtb2RlX2NtZCA9IHsgMCB9Owo+ICAKPiBAQCAtMTAxMDAsNyArMTAwOTgsMTEgQEAgaW50
ZWxfZnJhbWVidWZmZXJfY3JlYXRlX2Zvcl9tb2RlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g
IAkJCQkJCQkJYnBwKTsKPiAgCW1vZGVfY21kLnBpeGVsX2Zvcm1hdCA9IGRybV9tb2RlX2xlZ2Fj
eV9mYl9mb3JtYXQoYnBwLCBkZXB0aCk7Cj4gIAo+IC0JcmV0dXJuIGludGVsX2ZyYW1lYnVmZmVy
X2NyZWF0ZShkZXYsICZtb2RlX2NtZCwgb2JqKTsKPiArCWZiID0gaW50ZWxfZnJhbWVidWZmZXJf
Y3JlYXRlKGRldiwgJm1vZGVfY21kLCBvYmopOwo+ICsJaWYgKElTX0VSUihmYikpCj4gKwkJZHJt
X2dlbV9vYmplY3RfdW5yZWZlcmVuY2VfdW5sb2NrZWQoJm9iai0+YmFzZSk7Cj4gKwo+ICsJcmV0
dXJuIGZiOwo+ICB9Cj4gIAo+ICBzdGF0aWMgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqCj4gQEAg
LTE0Mjg5LDYgKzE0MjkxLDcgQEAgaW50ZWxfdXNlcl9mcmFtZWJ1ZmZlcl9jcmVhdGUoc3RydWN0
IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJICAgICAgc3RydWN0IGRybV9maWxlICpmaWxwLAo+ICAJ
CQkgICAgICBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQpCj4gIHsKPiArCXN0cnVj
dCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9i
ajsKPiAgCj4gIAlvYmogPSB0b19pbnRlbF9ibyhkcm1fZ2VtX29iamVjdF9sb29rdXAoZGV2LCBm
aWxwLAo+IEBAIC0xNDI5Niw3ICsxNDI5OSwxMSBAQCBpbnRlbF91c2VyX2ZyYW1lYnVmZmVyX2Ny
ZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJaWYgKCZvYmotPmJhc2UgPT0gTlVMTCkK
PiAgCQlyZXR1cm4gRVJSX1BUUigtRU5PRU5UKTsKPiAgCj4gLQlyZXR1cm4gaW50ZWxfZnJhbWVi
dWZmZXJfY3JlYXRlKGRldiwgbW9kZV9jbWQsIG9iaik7Cj4gKwlmYiA9IGludGVsX2ZyYW1lYnVm
ZmVyX2NyZWF0ZShkZXYsIG1vZGVfY21kLCBvYmopOwo+ICsJaWYgKElTX0VSUihmYikpCj4gKwkJ
ZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2VfdW5sb2NrZWQoJm9iai0+YmFzZSk7Cj4gKwo+ICsJ
cmV0dXJuIGZiOwoKVGhpcyBvbmUgbG9va3MgZ29vZCB0byBtZQpSZXZpZXdlZC1ieTogVmlsbGUg
U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gIH0KPiAgCj4gICNp
Zm5kZWYgQ09ORklHX0RSTV9GQkRFVl9FTVVMQVRJT04KPiAtLSAKPiAyLjEuMAoKLS0gClZpbGxl
IFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
bnRlbC1nZngK