From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlzM8-0005t3-1b for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlzM5-000827-Au for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:11:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlzM5-000822-5p for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:11:01 -0400 Date: Tue, 13 Oct 2015 16:10:56 +0300 From: "Michael S. Tsirkin" Message-ID: <20151013160807-mutt-send-email-mst@redhat.com> References: <1444725695-27517-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20151013114852-mutt-send-email-mst@redhat.com> <561CF0DF.80506@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561CF0DF.80506@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v3 0/2] PCI-e device multi-function hot-add support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: pbonzini@redhat.com, alex.williamson@redhat.com, qemu-devel@nongnu.org, izumi.taku@jp.fujitsu.com On Tue, Oct 13, 2015 at 07:54:07PM +0800, Cao jin wrote: > > > On 10/13/2015 04:49 PM, Michael S. Tsirkin wrote: > >On Tue, Oct 13, 2015 at 04:41:33PM +0800, Cao jin wrote: > >>Support PCI-e device hot-add multi-function via device_add, just ensure > >>add the function 0 is added last. While allow user to roll back in the > >>middle via device_del, in case user regret. > > > >This patch doesn't seem to account of AIR though. > > > > Yes, but the AIR function seems never be used(nobody calls the function > pcie_ari_init()), so I am a little confused about should it be consindered? Yes please - we'll likely use that in the future. Pls add an API that takes ari into account. > >>changelog: > >>1. Flag device as unexposed when func 0 doesn`t exist, via return 0xFF > >> in case of gratuitous pci bus scan. > >>2. Since device is unexposed to guest, can remove function individually, > >> without interaction with the guest. > >> > >>Cao jin (2): > >> enable multi-function hot-add > >> remove function during multi-function hot-add > >> > >> hw/pci/pci.c | 10 ++++++++++ > >> hw/pci/pci_host.c | 6 +++++- > >> hw/pci/pcie.c | 38 +++++++++++++++++++++++++------------- > >> 3 files changed, 40 insertions(+), 14 deletions(-) > >> > >>-- > >>2.1.0 > >. > > > > -- > Yours Sincerely, > > Cao Jin