From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] Revert "ipv4/icmp: redirect messages can use
 the ingress daddr as source"
Date: Wed, 14 Oct 2015 06:02:03 -0700 (PDT)
Message-ID: <20151014.060203.761451152118070620.davem@davemloft.net>
References: <4e53a9f0ca945e532b6598e6bdc7254d2ce47c43.1444825488.git.pabeni@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, corbet@lwn.net, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net
To: pabeni@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([149.20.54.216]:59777 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932172AbbJNMqC (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 14 Oct 2015 08:46:02 -0400
In-Reply-To: <4e53a9f0ca945e532b6598e6bdc7254d2ce47c43.1444825488.git.pabeni@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 14 Oct 2015 14:25:53 +0200

> Revert the commit e2ca690b657f ("ipv4/icmp: redirect messages
> can use the ingress daddr as source"), which tried to introduce a more
> suitable behaviour for ICMP redirect messages generated by VRRP routers.
> However RFC 5798 section 8.1.1 states:
> 
>     The IPv4 source address of an ICMP redirect should be the address
>     that the end-host used when making its next-hop routing decision.
> 
> while said commit used the generating packet destination
> address, which do not match the above and in most cases leads to
> no redirect packets to be generated.
> 
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Applied, thanks.

I honestly still didn't like the change at all, but begrudgedly applied
it hoping to avoid people saying crap like "Linux refuses to support VRRP"...