From: Shivani Bhardwaj <shivanib134@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH] Staging: rtl8723au: rtw_xmit: Remove extra NULL tests
Date: Wed, 14 Oct 2015 06:21:12 +0530 [thread overview]
Message-ID: <20151014005112.GA26569@ubuntu> (raw)
Variables already tested for NULL value are checked again so, the extra
NULL tests should be removed.
Semantic patch used:
@@ expression E; @@
if(E==NULL) {... return...;}
- if(E)
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index a4b6bb6..0ea521b 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -667,7 +667,6 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
if (pattrib->encrypt == WLAN_CIPHER_SUITE_TKIP) {
/* encode mic code */
- if (stainfo) {
u8 null_key[16]={0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0,
@@ -792,10 +791,6 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
*(payload + curfragnum + 6),
*(payload + curfragnum + 7));
}
- } else {
- RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_,
- "xmitframe_addmic: rtw_get_stainfo23a ==NULL!!!\n");
- }
}
return _SUCCESS;
@@ -934,7 +929,6 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
/* TODO: fill HT Control Field */
/* Update Seq Num will be handled by f/w */
- if (psta) {
psta->sta_xmitpriv.txseq_tid[pattrib->priority]++;
psta->sta_xmitpriv.txseq_tid[pattrib->priority] &= 0xFFF;
pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];
@@ -970,7 +964,6 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
pattrib->ampdu_en = true;/* AGG EN */
}
}
- }
}
exit:
return res;
@@ -1132,7 +1125,6 @@ int rtw_xmitframe_coalesce23a(struct rtw_adapter *padapter, struct sk_buff *skb,
/* adding icv, if necessary... */
if (pattrib->iv_len) {
- if (psta) {
switch (pattrib->encrypt) {
case WLAN_CIPHER_SUITE_WEP40:
case WLAN_CIPHER_SUITE_WEP104:
@@ -1158,7 +1150,6 @@ int rtw_xmitframe_coalesce23a(struct rtw_adapter *padapter, struct sk_buff *skb,
psta->dot11txpn, 0);
break;
}
- }
memcpy(pframe, pattrib->iv, pattrib->iv_len);
--
2.1.0
next reply other threads:[~2015-10-14 0:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 0:51 Shivani Bhardwaj [this message]
2015-10-14 5:48 ` [Outreachy kernel] [PATCH] Staging: rtl8723au: rtw_xmit: Remove extra NULL tests Julia Lawall
2015-10-14 9:08 ` Shivani Bhardwaj
2015-10-14 9:09 ` Shivani Bhardwaj
2015-10-14 9:14 ` Julia Lawall
2015-10-14 9:17 ` Shivani Bhardwaj
2015-10-14 9:51 ` Julia Lawall
2015-10-14 9:54 ` Shivani Bhardwaj
2015-10-14 10:00 ` Julia Lawall
2015-10-14 10:02 ` Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014005112.GA26569@ubuntu \
--to=shivanib134@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.