All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] luvi: new package
Date: Wed, 14 Oct 2015 08:07:24 +0300	[thread overview]
Message-ID: <20151014050724.GA2391@sapphire.tkos.co.il> (raw)
In-Reply-To: <1444763952-29583-1-git-send-email-joerg.krause@embedded.rocks>

Hi J?rg,

On Tue, Oct 13, 2015 at 09:19:12PM +0200, J?rg Krause wrote:
> +# Dispatch all architectures of LuaJIT
> +ifeq ($(BR2_i386),y)
> +TARGET_ARCH = x86
> +else ifeq ($(BR2_x86_64),y)
> +TARGET_ARCH = x64
> +else ifeq ($(BR2_powerpc),y)
> +TARGET_ARCH = ppc
> +else ifeq ($(BR2_arm)$(BR2_armeb),y)
> +TARGET_ARCH = arm
> +else ifeq ($(BR2_mips)$(BR2_mipsel),y)
> +TARGET_ARCH = mips
> +else
> +TARGET_ARCH = $(BR2_ARCH)
> +endif

TARGET_ARCH is too generic for a Makefile variable. It might conflict with 
something else since the Makefile namespace is global. Please use something 
like LUVI_TARGET_ARCH.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-10-14  5:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 19:19 [Buildroot] [PATCH 1/1] luvi: new package Jörg Krause
2015-10-14  5:07 ` Baruch Siach [this message]
2015-10-14 20:35 ` [Buildroot] [PATCH v2 " Jörg Krause
2015-10-14 20:48   ` Thomas Petazzoni
2015-10-14 21:12   ` Jerzy Grzegorek
2015-10-15  6:25     ` Jörg Krause
2015-10-15  6:29   ` [Buildroot] [PATCH v3 " Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014050724.GA2391@sapphire.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.