From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmMnV-0002ud-UH for qemu-devel@nongnu.org; Wed, 14 Oct 2015 10:12:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmMnR-0000At-9Y for qemu-devel@nongnu.org; Wed, 14 Oct 2015 10:12:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmMnQ-0000A5-Pu for qemu-devel@nongnu.org; Wed, 14 Oct 2015 10:12:48 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 364B4C0B64A5 for ; Wed, 14 Oct 2015 14:12:48 +0000 (UTC) Date: Wed, 14 Oct 2015 17:12:44 +0300 From: "Michael S. Tsirkin" Message-ID: <20151014165126-mutt-send-email-mst@redhat.com> References: <18ab6aea9a24a21bf2686a2ab220434951d53dc0.1444824439.git.amit.shah@redhat.com> <87r3kxpovo.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r3kxpovo.fsf@neno.neno> Subject: Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Amit Shah , Jason Wang , qemu list , "Dr. David Alan Gilbert" On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > Amit Shah wrote: > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > there were errors detected after this announcement was done, the > > migration is failed and the VM could continue running on the src host -- > > causing problems later. > > > > Move around the qemu_announce_self() call so it's done just before the > > VM is runnable. > > > > Signed-off-by: Amit Shah > > Reviewed-by: Juan Quintela > > applied. > > I have the same question than Dave, but also agree that this is a > movement in the right direction. > > Why it is not only needed when we do a vm_start()? It's a complex question. We don't want to do this on each vmstop/vmcont. But maybe we want to, on the 1st vmstart after qemu is started. > And why we can't delay it until that happens? > > Later, Juan.