From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964776AbbJNUKj (ORCPT ); Wed, 14 Oct 2015 16:10:39 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:60906 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932172AbbJNUKb (ORCPT ); Wed, 14 Oct 2015 16:10:31 -0400 Date: Wed, 14 Oct 2015 22:10:21 +0200 From: Karsten Merker To: "Tirdea, Irina" Cc: Karsten Merker , Bastien Nocera , Dmitry Torokhov , Aleksei Mamlin , "linux-input@vger.kernel.org" , Ian Campbell , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chen-Yu Tsai Subject: Re: [PATCH RFC V2 1/3] Input: goodix - add dt axis swapping and axis inversion support Message-ID: <20151014201021.GA1799@excalibur.cnev.de> References: <1444413352-24529-1-git-send-email-merker@debian.org> <1444413352-24529-2-git-send-email-merker@debian.org> <1F3AC3675D538145B1661F571FE1805F2F0FE498@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1F3AC3675D538145B1661F571FE1805F2F0FE498@irsmsx105.ger.corp.intel.com> X-No-Archive: yes User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:lTtzKqoOsmypFdtv6JOSIhchbFzIIZJwpDK0VylGeJ8VB23k3xH t5VpQbBxBGLRZMUDBcNH1LiTSV42M5wZZrF8y7u6EvIw63NC0q9GaT9TiQVBHcpgnSX7+aP igOsAvktzrBnD3W4nVKtMgRt/nOAvIo3Aa2ptihaO67wU5LxoV89v75u5JOGKfAvson6Sq1 oVb/vE1sBQ5RoKK0MnQ8Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:qAqRS6nNrA4=:/D6iHrOYPBSD6lZ10KURg3 ixnl4ZcK/LE8cdcSrDeNyY3L8O1F1scBHs7sn0LhIzyPhcBtOJOnu2fd58ug85o64QXj9K7u/ BxbSdIzJG634bOLaaeLn0NRDMYa1euJyem1vzEGxdBNFOM+HxVtt71TLoE9NechBh2efw1Q6R sLEapo3uIck9kyZgpMkhwSaZx6w/DVxfc6z7TtYN4pzqLaAwORvwqwq/6wvFy7NaoVoKP1yJh yEpu8MVdIajfbVd35/La57UaVE16k3HERyoqvOC3bru24Bib5PtGz8MJcyikBagNP5HW98ccZ FHPtsB846OliZcMkKuTM8PQcYLvS1I+bzv+eMj6I9m1ndRGJXawwM74ZcGcWmPcX40J1/qOwT UVBZKjibDShLAugQSduJAcR1qfiOp3A119MfnE513MkZdqxeG7uFR0rfbEm1gpnFa1eiYFtL9 nLaJvB4wv+l6OQpLrwjtDEmj1zEtaNinsEHl0ONl00X6NUhQvqh8iltiK3WkpNwhK1/Afs1vh Bp4DEhzykH4b+JW1K19/hF5pIaFT+8L75M/gKFObzEXODzgkHF7/dUVXzzAe2te5vyZ5XmhTI q+BMQFXFYMeYCJJBcnAMRvSqUW/jmTBf4GpKW6dhjNHxsCW3A2xVrim3J371WFOavVR2jC9Bk P7g0Ty2ZJINJL7Gc5x9iG9xKKy/dF0jY9xHpZ992YDdu/3rVmFUfuF1/2fOGwPLCxkN0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 06:58:07AM +0000, Tirdea, Irina wrote: > > > -----Original Message----- > > From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Karsten Merker > > Sent: 09 October, 2015 20:56 > > To: Bastien Nocera; Dmitry Torokhov; Tirdea, Irina; Aleksei Mamlin; linux-input@vger.kernel.org; Ian Campbell > > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Chen-Yu Tsai; Karsten Merker > > Subject: [PATCH RFC V2 1/3] Input: goodix - add dt axis swapping and axis inversion support > > > > Implement support for the following device-tree properties > > in the goodix touchscreen driver: > > > > - touchscreen-inverted-x: X axis is inverted (boolean) > > - touchscreen-inverted-y: Y axis is inverted (boolean) > > - touchscreen-swapped-x-y: X and Y axis are swapped (boolean) > > > > These are necessary on tablets which have a display in portrait > > format while the touchscreen is in landscape format, such as e.g. > > the MSI Primo 81. [...] > > @@ -950,6 +968,15 @@ static int goodix_ts_probe(struct i2c_client *client, > > return 0; > > } > > > > +#ifdef CONFIG_OF > > + ts->swapped_x_y = of_property_read_bool(client->dev.of_node, > > + "touchscreen-swapped-x-y"); > > + ts->inverted_x = of_property_read_bool(client->dev.of_node, > > + "touchscreen-inverted-x"); > > + ts->inverted_y = of_property_read_bool(client->dev.of_node, > > + "touchscreen-inverted-y"); > > +#endif > > + > > If interrupt and reset gpio pins are declared in the DT configuration, this code will not > be executed. To make the properties available for all configurations (with/without > gpio pins declared), you should read the properties inside goodix_configure_dev(). > > You could also use device_property_read_bool() instead, so that these properties can > be used with ACPI 5.1. as well. Hello, many thanks for the review. I'll address both points in a v3 of the patch. Regards, Karsten -- Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der Werbung sowie der Markt- oder Meinungsforschung.