From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbbJOLG2 (ORCPT ); Thu, 15 Oct 2015 07:06:28 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42518 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbJOLG1 (ORCPT ); Thu, 15 Oct 2015 07:06:27 -0400 Date: Thu, 15 Oct 2015 07:06:14 -0400 From: Sowmini Varadhan To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-api@vger.kernel.org Subject: Re: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h Message-ID: <20151015110614.GL948@oracle.com> References: <1444888618-4506-1-git-send-email-mikko.rapeli@iki.fi> <1444888618-4506-24-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1444888618-4506-24-git-send-email-mikko.rapeli@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (10/15/15 07:56), Mikko Rapeli wrote: > Date: Thu, 15 Oct 2015 07:56:01 +0200 > From: Mikko Rapeli > To: linux-kernel@vger.kernel.org > Cc: mikko.rapeli@iki.fi, "David S. Miller" , Sowmini > Varadhan , linux-api@vger.kernel.org > Subject: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64 > from linux/types.h > X-Mailer: git-send-email 2.6.1 > > Fixes userspace compilation errors like: > > linux/rds.h:96:2: error: unknown type name ‘uint8_t’ Can't you just include in linux/rds.h? (similar to the fix for linux/rds)? It would reduce the deltas significantly, and portable applications are likely to expect uint8_t etc anyway. --Sowmini From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h Date: Thu, 15 Oct 2015 07:06:14 -0400 Message-ID: <20151015110614.GL948@oracle.com> References: <1444888618-4506-1-git-send-email-mikko.rapeli@iki.fi> <1444888618-4506-24-git-send-email-mikko.rapeli@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1444888618-4506-24-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mikko Rapeli Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On (10/15/15 07:56), Mikko Rapeli wrote: > Date: Thu, 15 Oct 2015 07:56:01 +0200 > From: Mikko Rapeli > To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: mikko.rapeli-X3B1VOXEql0@public.gmane.org, "David S. Miller" , Sow= mini > Varadhan , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Subject: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __= s64 > from linux/types.h > X-Mailer: git-send-email 2.6.1 >=20 > Fixes userspace compilation errors like: >=20 > linux/rds.h:96:2: error: unknown type name =E2=80=98uint8_t=E2=80=99 Can't you just include in linux/rds.h? (similar to the fix for linux/rds)? It would reduce the deltas significantly,=20 and portable applications are likely to expect uint8_t etc anyway. --Sowmini