From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmgjM-0005Fu-EN for qemu-devel@nongnu.org; Thu, 15 Oct 2015 07:29:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmgjL-0005T9-JD for qemu-devel@nongnu.org; Thu, 15 Oct 2015 07:29:56 -0400 Date: Thu, 15 Oct 2015 13:29:45 +0200 From: Kevin Wolf Message-ID: <20151015112945.GA4302@noname.redhat.com> References: <1444680042-13207-1-git-send-email-mreitz@redhat.com> <1444680042-13207-27-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444680042-13207-27-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-block@nongnu.org, John Snow , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: > Most of the options which blockdev_init() parses for both the > BlockBackend and the root BDS are valid for just the root BDS as well > (e.g. read-only). This patch allows specifying these options even if not > creating a BlockBackend. > > Signed-off-by: Max Reitz > --- > blockdev.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 154 insertions(+), 6 deletions(-) > + > + /* disk I/O throttling */ > + if (throttle_enabled(&cfg)) { > + if (!throttling_group) { > + throttling_group = bdrv_get_node_name(bs); > + } > + bdrv_io_limits_enable(bs, throttling_group); > + bdrv_set_io_limits(bs, &cfg); > + } A while ago we discussed that we want to move throttling to the BB level eventually. In that case, it might be wiser not to expose it for non-BB nodes now. Otherwise the patch looks good to me. Kevin