From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 1/5] eal: refactor plugin list append from eal_parse_args() to a helper function Date: Fri, 16 Oct 2015 13:57:28 +0100 Message-ID: <20151016125727.GB9980@bricha3-MOBL3> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4281BE72 for ; Fri, 16 Oct 2015 14:57:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2015 at 02:58:13PM +0300, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/linuxapp/eal/eal.c | 28 +++++++++++++++++++--------- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c > index 33e1067..cc66d9f 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -530,6 +530,24 @@ eal_log_level_parse(int argc, char **argv) > optind = 0; /* reset getopt lib */ > } > > +static int > +eal_plugin_add(const char *path) > +{ > + struct shared_driver *solib; > + > + solib = malloc(sizeof(*solib)); > + if (solib == NULL) { > + RTE_LOG(ERR, EAL, "malloc(solib) failed\n"); > + return -1; > + } > + memset(solib, 0, sizeof(*solib)); > + strncpy(solib->name, path, PATH_MAX-1); > + solib->name[PATH_MAX-1] = 0; I always prefer a one-line snprintf to the above two-line code. :-) /Bruce