From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422655AbbJRC4k (ORCPT ); Sat, 17 Oct 2015 22:56:40 -0400 Received: from mout.gmx.net ([212.227.17.22]:52664 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932779AbbJRC4h (ORCPT ); Sat, 17 Oct 2015 22:56:37 -0400 From: Peter =?iso-8859-15?q?H=FCwe?= To: Jarkko Sakkinen Subject: Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address Date: Sun, 18 Oct 2015 05:02:55 +0200 User-Agent: KMail/1.13.7 (Linux/4.2.3-dirty; KDE/4.14.8; x86_64; ; ) Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Marcel Selhorst References: <1445020843-9382-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1445020843-9382-2-git-send-email-jarkko.sakkinen@linux.intel.com> In-Reply-To: <1445020843-9382-2-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201510180502.55677.PeterHuewe@gmx.de> X-Provags-ID: V03:K0:GM4Q7/12ZbyLvXefoUx476Z4k4sA3Ug9/4SkF9quOSCas97schS sosZYQG5n22EzPQZErz6Jwx2he/Qf9NQ9Y7rKv9EpsXcnKaQBOQ4s3vF1DXMcQ5UGNmH3H9 nL0/lRw9pxm8f03jMQg7ROfWti3+UXxeohgyrDjVyB7O9H4+hPyII2/JYGyGCjcJG8+zLyE DPd0ZxWZH+XYvweDecTiA== X-UI-Out-Filterresults: notjunk:1;V01:K0:10NEKK5ggNc=:gSg9d9kLXrwQAISuIjmFCM Tma+WM9lmRm7XleSdx6etUH11nnecd7RbgW8ySaSrN8+cKBNpgFycbzUjbSYN5d7wMmCNQB5m WavJGFzQSB18Oljsl3X0iu7o/OXasPAkVp9o1J+Z6CgGc3FxOPLzD9VfYpDjRMCbFj7sxUD1v JOssXMxImTLmbjvDewmFOpM17h3DCTeUkpmncXUNcSuuj2OacdP0INSxfTMQMb00BUvXypBhg GE7DzxBnNHFOrpgTnM3TUun3JgMw1z+1YdtISnlPg7opdTSvumUzXjxC6Vr4hiT3fgxkGytRb NmfojjQAV5x+PEC7VOO60yut7c+X0gs+y9VFrIAl5gXtEGXeNuEUKwaKpOziCLNzer4UVhurF kjqHkjDvUTx/semKys/4iCf6ViwsOSHkUWVaK6ysz1JmZJhDthHJG0U+djpZ8TXzn5ezbApaW yP3zfGfzNg4mIXyI0aQXOro679TCt+MFaQu2IUfr0Cm/IeMWYuxIkE4J2Fs7DeDyRYRtQm21W 2dbtFVsJSI05iX+PnDka1CT2wdIdPO0XO9iSzMLz2MO4yKJYW6OoenciR5SnnLNawqpxpmISV 0RjDACggFtYhc8XuhFtGZkZX4ew69JMRHyWQ2UGDCTcD7fRq2039yK6R9yrG7o+R/6yinjFAs Ra0On/ij4f79l/xgyPvUKKCyOsIOpASpyXyDQvCzhMtRIiNYMKYSfG+LeekLUhmi7PJ7qpFoy TqOmGcroJW2cGvVjt43GEN7G/Z8oQ5KHk6KWydm901Wnk8JX1utoIuqabriTImNIDYDdGT3IW eiqo+9I Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 16. Oktober 2015, 20:40:20 schrieb Jarkko Sakkinen: > + pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) + > + (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low)); The canonical form would be > + pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) | > + (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low)); ? Or am I missing something? Shall I fix-up? Thanks, Peter