All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Peter Hüwe" <PeterHuewe@gmx.de>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com,
	dhowells@redhat.com, artem.bityutskiy@linux.intel.com,
	Marcel Selhorst <tpmdd@selhorst.net>
Subject: Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address
Date: Sun, 18 Oct 2015 14:15:36 +0300	[thread overview]
Message-ID: <20151018111536.GA7391@intel.com> (raw)
In-Reply-To: <201510180502.55677.PeterHuewe@gmx.de>

On Sun, Oct 18, 2015 at 05:02:55AM +0200, Peter Hüwe wrote:
> Am Freitag, 16. Oktober 2015, 20:40:20 schrieb Jarkko Sakkinen:
> > +       pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) +
> > +               (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low));
> 
> The canonical form would be 
> > +       pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) |
> > +               (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low));
> ?
> Or am I missing something?
> Shall I fix-up?

Please do. Current works but definitely your form is correct.

> Thanks,
> Peter

/Jarkko

  reply	other threads:[~2015-10-18 11:16 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 18:40 [PATCH 00/10] TPM2 updates for 4.4 Jarkko Sakkinen
2015-10-16 18:40 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen
2015-10-18  3:02   ` Peter Hüwe
2015-10-18 11:15     ` Jarkko Sakkinen [this message]
2015-10-16 18:40 ` [PATCH 02/10] tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0 Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen
2015-10-18  1:37   ` Peter Hüwe
2015-10-18 11:21     ` Jarkko Sakkinen
2015-11-07  0:23   ` Jeremiah Mahler
2015-11-09 22:32     ` Jason Gunthorpe
2015-11-07  2:55   ` [BUG, PATCH " Jeremiah Mahler
2015-11-07 10:55     ` Jarkko Sakkinen
2015-11-07 11:41       ` Jarkko Sakkinen
2015-11-07 18:08         ` Jeremiah Mahler
2015-11-07 22:31           ` Jarkko Sakkinen
2015-11-07 23:11             ` Jeremiah Mahler
2015-11-08  0:49               ` Jarkko Sakkinen
2015-11-08  3:04                 ` Jeremiah Mahler
2015-11-08  7:46                   ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 04/10] tpm: move the PPI attributes to character device directory Jarkko Sakkinen
2015-11-04 18:17   ` [BUG, bisect, PATCH " Jeremiah Mahler
2015-11-05  9:22     ` Jarkko Sakkinen
2015-11-05 11:05       ` [tpmdd-devel] " Jarkko Sakkinen
2015-11-05 16:47         ` Jeremiah Mahler
2015-11-05 17:46           ` Jarkko Sakkinen
2015-11-05 18:17             ` Jeremiah Mahler
2015-11-06 13:45               ` Jarkko Sakkinen
2015-11-07  2:54     ` Jeremiah Mahler
2015-10-16 18:40 ` [PATCH 05/10] tpm: update PPI documentation to address the location change Jarkko Sakkinen
2015-10-16 18:40   ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 06/10] tpm: introduce tpm_buf Jarkko Sakkinen
2015-10-18  2:57   ` Peter Hüwe
2015-10-18 11:19     ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 07/10] keys, trusted: move struct trusted_key_options to trusted-type.h Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 08/10] tpm: seal/unseal for TPM 2.0 Jarkko Sakkinen
2015-11-07 18:58   ` Jeremiah Mahler
2015-11-07 21:39     ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 09/10] keys, trusted: seal/unseal with TPM 2.0 chips Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 10/10] MAINTAINERS: add new maintainer for TPM DEVICE DRIVER Jarkko Sakkinen
2015-10-16 19:06 ` [tpmdd-devel] [PATCH 00/10] TPM2 updates for 4.4 Kevin Strasser
2015-10-16 19:06   ` Kevin Strasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151018111536.GA7391@intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=PeterHuewe@gmx.de \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.