From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752627AbbJTNms (ORCPT <rfc822;w@1wt.eu>);
	Tue, 20 Oct 2015 09:42:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58324 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752567AbbJTNmr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 20 Oct 2015 09:42:47 -0400
Date: Tue, 20 Oct 2015 11:42:43 -0200
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>, acme@kernel.org, ast@plumgrid.com,
        brendan.d.gregg@gmail.com, a.p.zijlstra@chello.nl,
        daniel@iogearbox.net, dsahern@gmail.com, hekuang@huawei.com,
        jolsa@kernel.org, lizefan@huawei.com, masami.hiramatsu.pt@hitachi.com,
        paulus@samba.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        xiakaixu@huawei.com
Subject: Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test
Message-ID: <20151020134243.GF4400@redhat.com>
References: <1444826502-49291-1-git-send-email-wangnan0@huawei.com>
 <1444826502-49291-22-git-send-email-wangnan0@huawei.com>
 <20151019144231.GA14297@danjae.kornet>
 <20151019145312.GA2359@redhat.com>
 <56261931.9020807@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56261931.9020807@huawei.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Oct 20, 2015 at 06:36:33PM +0800, Wangnan (F) escreveu:
> On 2015/10/19 22:53, Arnaldo Carvalho de Melo wrote:
> >Em Mon, Oct 19, 2015 at 11:42:31PM +0900, Namhyung Kim escreveu:
> >>On Wed, Oct 14, 2015 at 12:41:32PM +0000, Wang Nan wrote:
> >>>This patch enforces existing LLVM test, makes it compile more than one
> >>>BPF source file. The compiled results are stored, can be used for other
> >>>testcases. Except the first testcase (named LLVM_TESTCASE_BASE), failures
> >>>of other test cases are not considered as failure of the whole test.

> >>>Adds a kbuild testcase to check whether kernel headers can be correctly
> >>>found.

> >>>For example:
> >>>  # perf test LLVM
> >>>    38: Test LLVM searching and compiling                        : (llvm.kbuild-dir can be fixed) Ok

> >>IMHO it'd be better to keep the test result simply as either "Ok" or
> >>"FAILED" and provide details with -v option.
> 
> I have to say I'm not the first one to output things like this:
> 
>  #perf test dummy attr
>  14: struct perf_event_attr setup                             :
> (omitted) Ok
>  23: Test using a dummy software event to keep tracking       : (not
> supported) Ok
> 
> Do you think they also need to be fixed?

yes
 
> >"Skipped" looks more natural here, with the reason for it skipping being shown
> >only with -v.
> 
> For this specific case, I will change the logic:
> 
>  1. When basic test failed (no clang, compiling error...), report failure;
> 
>  2. When basic test passed but kbuild test or later test cases
> failed, report
>     Skip.
> 
>  3. Don't output any other information.
> 
> Thank you.
> 
> >Ingo made some comments about 'perf test' output recently, have you read that?
> >
> >>Anyway I found the tracepoint error message is annoying in the current
> >You mean all these warnings:
> >
> >[root@zoo ~]# perf test "parse event"
> >  5: parse events tests                                       :  Warning: [sunrpc:xprt_lookup_rqst] function __builtin_constant_p not defined
> >   Warning: [sunrpc:xprt_transmit] function __builtin_constant_p not defined
> >   Warning: [sunrpc:xprt_complete_rqst] function __builtin_constant_p not defined
> ><SNIP>
> >   Warning: [xen:xen_mmu_set_pud] function sizeof not defined
> >   Warning: [xen:xen_mmu_set_pgd] function sizeof not defined
> >   Warning: [xen:xen_mmu_ptep_modify_prot_start] function sizeof not defined
> >   Warning: [xen:xen_mmu_ptep_modify_prot_commit] function sizeof not defined
> >  Ok
> >[root@zoo ~]#
> >
> >i.e. making those warnings appear only under 'perf test -v'? Cool!
> >
> >>perf test output.  Will send a fix soon.
> >>
> >>Thanks,
> >>Namhyung
>