From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2.9/5] drm/i915: Do not wait for flips in intel_crtc_disable_noatomic. Date: Tue, 20 Oct 2015 20:33:04 +0200 Message-ID: <20151020183304.GA13786@phenom.ffwll.local> References: <1443007632-5573-1-git-send-email-maarten.lankhorst@linux.intel.com> <1443007632-5573-4-git-send-email-maarten.lankhorst@linux.intel.com> <1445260613.3042.62.camel@gmail.com> <562507A3.3080901@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01ACA6E162 for ; Tue, 20 Oct 2015 11:33:08 -0700 (PDT) Received: by wicfv8 with SMTP id fv8so42173477wic.0 for ; Tue, 20 Oct 2015 11:33:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <562507A3.3080901@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDU6MDk6MjNQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTktMTAtMTUgb20gMTU6MTYgc2NocmVlZiBBbmRlciBDb25zZWx2YW4g RGUgT2xpdmVpcmE6Cj4gPiBPbiBXZWQsIDIwMTUtMDktMjMgYXQgMTM6MjcgKzAyMDAsIE1hYXJ0 ZW4gTGFua2hvcnN0IHdyb3RlOgo+ID4+IE1vdmUgaXQgZnJvbSBpbnRlbF9jcnRjX2F0b21pY19j b21taXQgdG8gcHJlcGFyZV9wbGFuZV9mYi4KPiA+PiBXYWl0aW5nIGlzIGRvbmUgYmVmb3JlIGNv bW1pdHRpbmcsIG90aGVyd2lzZSBpdCdzIHRvbyBsYXRlCj4gPj4gdG8gdW5kbyB0aGUgY2hhbmdl cy4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2F0b21pYy5jICB8ICAgMiAtCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyB8IDEwNyArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4g Pj4gLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgIDIgLQo+ ID4+ICAzIGZpbGVzIGNoYW5nZWQsIDYyIGluc2VydGlvbnMoKyksIDQ5IGRlbGV0aW9ucygtKQo+ ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5j Cj4gPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+ID4+IGluZGV4IGYx OTc1ZjI2NzcxMC4uMjVhODkxYWEzODI0IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2F0b21pYy5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXRvbWljLmMKPiA+PiBAQCAtMjA1LDggKzIwNSw2IEBAIGludCBpbnRlbF9hdG9taWNfc2V0 dXBfc2NhbGVycyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJCQkJICogYnV0IHNpbmNl IHRoaXMgcGxhbmUgaXMgdW5jaGFuZ2VkIGp1c3QgZG8KPiA+PiB0aGUKPiA+PiAgCQkJCSAqIG1p bmltdW0gcmVxdWlyZWQgdmFsaWRhdGlvbi4KPiA+PiAgCQkJCSAqLwo+ID4+IC0JCQkJaWYgKHBs YW5lLT50eXBlID09IERSTV9QTEFORV9UWVBFX1BSSU1BUlkpCj4gPj4gLQkJCQkJaW50ZWxfY3J0 Yy0+YXRvbWljLndhaXRfZm9yX2ZsaXBzID0KPiA+PiB0cnVlOwo+ID4+ICAJCQkJY3J0Y19zdGF0 ZS0+YmFzZS5wbGFuZXNfY2hhbmdlZCA9IHRydWU7Cj4gPj4gIAkJCX0KPiA+PiAgCj4gPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+IGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4gaW5kZXggMjVlMWVhYzI2MGZk Li5jZDY1MWZmNmMxNWIgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPj4gQEAgLTMyMjEsMzIgKzMyMjEsNiBAQCB2b2lkIGludGVsX2ZpbmlzaF9yZXNldChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4+ICAJZHJtX21vZGVzZXRfdW5sb2NrX2FsbChkZXYp Owo+ID4+ICB9Cj4gPj4gIAo+ID4+IC1zdGF0aWMgdm9pZAo+ID4+IC1pbnRlbF9maW5pc2hfZmIo c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqb2xkX2ZiKQo+ID4+IC17Cj4gPj4gLQlzdHJ1Y3QgZHJt X2k5MTVfZ2VtX29iamVjdCAqb2JqID0gaW50ZWxfZmJfb2JqKG9sZF9mYik7Cj4gPj4gLQlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KG9iai0+YmFzZS5kZXYpOwo+ ID4+IC0JYm9vbCB3YXNfaW50ZXJydXB0aWJsZSA9IGRldl9wcml2LT5tbS5pbnRlcnJ1cHRpYmxl Owo+ID4+IC0JaW50IHJldDsKPiA+PiAtCj4gPj4gLQkvKiBCaWcgSGFtbWVyLCB3ZSBhbHNvIG5l ZWQgdG8gZW5zdXJlIHRoYXQgYW55IHBlbmRpbmcKPiA+PiAtCSAqIE1JX1dBSVRfRk9SX0VWRU5U IGluc2lkZSBhIHVzZXIgYmF0Y2ggYnVmZmVyIG9uIHRoZQo+ID4+IC0JICogY3VycmVudCBzY2Fu b3V0IGlzIHJldGlyZWQgYmVmb3JlIHVucGlubmluZyB0aGUgb2xkCj4gPj4gLQkgKiBmcmFtZWJ1 ZmZlci4gTm90ZSB0aGF0IHdlIHJlbHkgb24gdXNlcnNwYWNlIHJlbmRlcmluZwo+ID4+IC0JICog aW50byB0aGUgYnVmZmVyIGF0dGFjaGVkIHRvIHRoZSBwaXBlIHRoZXkgYXJlIHdhaXRpbmcKPiA+ PiAtCSAqIG9uLiBJZiBub3QsIHVzZXJzcGFjZSBnZW5lcmF0ZXMgYSBHUFUgaGFuZyB3aXRoIElQ RUhSCj4gPj4gLQkgKiBwb2ludCB0byB0aGUgTUlfV0FJVF9GT1JfRVZFTlQuCj4gPj4gLQkgKgo+ ID4+IC0JICogVGhpcyBzaG91bGQgb25seSBmYWlsIHVwb24gYSBodW5nIEdQVSwgaW4gd2hpY2gg Y2FzZSB3ZQo+ID4+IC0JICogY2FuIHNhZmVseSBjb250aW51ZS4KPiA+PiAtCSAqLwo+ID4+IC0J ZGV2X3ByaXYtPm1tLmludGVycnVwdGlibGUgPSBmYWxzZTsKPiA+PiAtCXJldCA9IGk5MTVfZ2Vt X29iamVjdF93YWl0X3JlbmRlcmluZyhvYmosIHRydWUpOwo+ID4+IC0JZGV2X3ByaXYtPm1tLmlu dGVycnVwdGlibGUgPSB3YXNfaW50ZXJydXB0aWJsZTsKPiA+PiAtCj4gPj4gLQlXQVJOX09OKHJl dCk7Cj4gPj4gLX0KPiA+PiAtCj4gPj4gIHN0YXRpYyBib29sIGludGVsX2NydGNfaGFzX3BlbmRp bmdfZmxpcChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPj4gIHsKPiA+PiAgCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gPj4gQEAgLTM4NjcsMTUgKzM4NDEsMjMgQEAgc3Rh dGljIHZvaWQgcGFnZV9mbGlwX2NvbXBsZXRlZChzdHJ1Y3QgaW50ZWxfY3J0Ywo+ID4+ICppbnRl bF9jcnRjKQo+ID4+ICAJCQkJIHdvcmstPnBlbmRpbmdfZmxpcF9vYmopOwo+ID4+ICB9Cj4gPj4g IAo+ID4+IC12b2lkIGludGVsX2NydGNfd2FpdF9mb3JfcGVuZGluZ19mbGlwcyhzdHJ1Y3QgZHJt X2NydGMgKmNydGMpCj4gPj4gK3N0YXRpYyBpbnQgaW50ZWxfY3J0Y193YWl0X2Zvcl9wZW5kaW5n X2ZsaXBzKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+PiAgewo+ID4+ICAJc3RydWN0IGRybV9k ZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiA+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPj4gKwlsb25nIHJldDsKPiA+PiAgCj4gPj4g IAlXQVJOX09OKHdhaXRxdWV1ZV9hY3RpdmUoJmRldl9wcml2LT5wZW5kaW5nX2ZsaXBfcXVldWUp KTsKPiA+PiAtCWlmIChXQVJOX09OKHdhaXRfZXZlbnRfdGltZW91dChkZXZfcHJpdi0+cGVuZGlu Z19mbGlwX3F1ZXVlLAo+ID4+IC0JCQkJICAgICAgICFpbnRlbF9jcnRjX2hhc19wZW5kaW5nX2Zs aXAoY3J0YyksCj4gPj4gLQkJCQkgICAgICAgNjAqSFopID09IDApKSB7Cj4gPj4gKwo+ID4+ICsJ cmV0ID0gd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlX3RpbWVvdXQoCj4gPj4gKwkJCQkJZGV2X3By aXYtPnBlbmRpbmdfZmxpcF9xdWV1ZSwKPiA+PiArCQkJCQkhaW50ZWxfY3J0Y19oYXNfcGVuZGlu Z19mbGlwKGNydGMpLAo+ID4+ICsJCQkJCTYwKkhaKTsKPiA+PiArCj4gPj4gKwlpZiAocmV0IDwg MCkKPiA+PiArCQlyZXR1cm4gcmV0Owo+ID4+ICsKPiA+PiArCWlmIChyZXQgPT0gMCkgewo+ID4+ ICAJCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsK PiA+PiAgCj4gPj4gIAkJc3Bpbl9sb2NrX2lycSgmZGV2LT5ldmVudF9sb2NrKTsKPiA+PiBAQCAt Mzg4NiwxMSArMzg2OCw3IEBAIHZvaWQgaW50ZWxfY3J0Y193YWl0X2Zvcl9wZW5kaW5nX2ZsaXBz KHN0cnVjdCBkcm1fY3J0Ywo+ID4+ICpjcnRjKQo+ID4+ICAJCXNwaW5fdW5sb2NrX2lycSgmZGV2 LT5ldmVudF9sb2NrKTsKPiA+PiAgCX0KPiA+PiAgCj4gPj4gLQlpZiAoY3J0Yy0+cHJpbWFyeS0+ ZmIpIHsKPiA+PiAtCQltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gPj4gLQkJaW50 ZWxfZmluaXNoX2ZiKGNydGMtPnByaW1hcnktPmZiKTsKPiA+PiAtCQltdXRleF91bmxvY2soJmRl di0+c3RydWN0X211dGV4KTsKPiA+PiAtCX0KPiA+IFRoZXJlIGlzIGFub3RoZXIgY2FsbGVyIG9m IGludGVsX2NydGNfd2FpdF9mb3JfcGVuZGluZ19mbGlwcygpIGJlc2lkZXMgdGhlIG9uZQo+ID4g dG91Y2hlZCBpbiB0aGlzIHBhdGNoOiBpbnRlbF9jcnRjX2Rpc2FibGVfbm9hdG9taWMoKS4gSW4g eW91ciBwcmV2aW91cyBzZXJpZXMKPiA+IHlvdSBkcm9wcGVkIHRoYXQgY2FsbCBiYXNlZCBvbiB0 aGUgZmFjdCB0aGF0IHRoZXJlIHNob3VsZG4ndCBiZSBhbnkgcGVuZGluZwo+ID4gZmxpcHMgYXQg dGhhdCBwb2ludCwgYnV0IHRoYXQgcGF0Y2ggaGFzIGJlZW4gZHJvcHBlZC4KPiA+Cj4gPiBXb3Vs ZG4ndCBpdCBiZSBiZXR0ZXIgdG8gYWRkIGEgV0FSTl9PTiBhcyBDaHJpcyBzdWdnZXN0ZWQgdGhl biBpbnN0ZWFkIG9mCj4gPiBrZWVwaW5nIHRoZSB3YWl0IGZvciBmbGlwcyBidXQgd2l0aG91dCB0 aGUgd29yayBhcm91bmQ/Cj4gPgo+IEFwcGx5IHdpdGggLS1zY2lzc29ycwo+IAo+IC0tLTg8LS0t LS0tCj4gaW50ZWxfY3J0Y19kaXNhYmxlX25vYXRvbWljIGlzIGNhbGxlZCBmcm9tIGh3IHJlYWRv dXQgZHVyaW5nIGluaXQsIHJlc3VtZSBhbmQgcG9zc2libHkgcmVzZXQuCj4gRHVyaW5nIGluaXQg aXQncyB0b28gZWFybHkgdG8gaGF2ZSBhIHBhZ2UgZmxpcCBxdWV1ZWQsIGJlZm9yZSBzdXNwZW5k aW5nIGFsbCBwYWdlIGZsaXBzCj4gc2hvdWxkIGJlIGZpbmlzaGVkIGFuZCBkdXJpbmcgaHcgcmVz ZXQgYWxsIHBhZ2UgZmxpcHMgc2hvdWxkIGJlIHJlbW92ZWQuCj4gCj4gSXQncyBhIGJ1ZyB3aGVu IHRoZXJlIGFyZSBwZW5kaW5nIGZsaXBzIGhlcmUsIGNvbXBsYWluIHdpdGggV0FSTl9PTiBpbnN0 ZWFkIG9mIGhhbmRsaW5nIGl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0 IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZjU5MDI5YzNlNTc3Li45NWM1OWI1MjAyYzUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTYyMjUsNyArNjIyNSw4IEBA IHN0YXRpYyB2b2lkIGludGVsX2NydGNfZGlzYWJsZV9ub2F0b21pYyhzdHJ1Y3QgZHJtX2NydGMg KmNydGMpCj4gIAkJcmV0dXJuOwo+ICAKPiAgCWlmICh0b19pbnRlbF9wbGFuZV9zdGF0ZShjcnRj LT5wcmltYXJ5LT5zdGF0ZSktPnZpc2libGUpIHsKPiAtCQlpbnRlbF9jcnRjX3dhaXRfZm9yX3Bl bmRpbmdfZmxpcHMoY3J0Yyk7Cj4gKwkJV0FSTl9PTihpbnRlbF9jcnRjLT51bnBpbl93b3JrKTsK PiArCj4gIAkJaW50ZWxfcHJlX2Rpc2FibGVfcHJpbWFyeShjcnRjKTsKPiAgCX0KPiAgCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=