From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbbJUI1F (ORCPT ); Wed, 21 Oct 2015 04:27:05 -0400 Received: from casper.infradead.org ([85.118.1.10]:48955 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbbJUI1D (ORCPT ); Wed, 21 Oct 2015 04:27:03 -0400 Date: Wed, 21 Oct 2015 10:27:14 +0200 From: Peter Zijlstra To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 4/5] perf, tools: Print branch filter state with -vv Message-ID: <20151021082714.GD2881@worktop.programming.kicks-ass.net> References: <1445366797-30894-1-git-send-email-andi@firstfloor.org> <1445366797-30894-4-git-send-email-andi@firstfloor.org> <20151020185135.GL5119@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151020185135.GL5119@kernel.org> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 03:51:35PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 11:46:36AM -0700, Andi Kleen escreveu: > > From: Andi Kleen > > > > Add a missing field to the perf_event_attr debug output. > > Thanks, applied. > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > > index e8724b4..2b75d56 100644 > > --- a/tools/perf/util/evsel.c > > +++ b/tools/perf/util/evsel.c > > @@ -1232,6 +1232,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr, > > PRINT_ATTRf(config, p_hex); > > PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned); > > PRINT_ATTRf(sample_type, p_sample_type); > > + PRINT_ATTRf(branch_sample_type, p_unsigned); > > PRINT_ATTRf(read_format, p_read_format); > > > > PRINT_ATTRf(disabled, p_unsigned); That's the wrong place.. it should be between config2 and sample_regs_user.