From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Turquette Subject: Re: [PATCH 01/10] clk/samsung: exynos5433: add definitions of HDMI-PHY output clocks Date: Wed, 21 Oct 2015 01:59:40 -0700 Message-ID: <20151021085940.20687.94974@quantum> References: <1445332961-25419-1-git-send-email-a.hajda@samsung.com> <1445332961-25419-2-git-send-email-a.hajda@samsung.com> <20151020103416.20687.40409@quantum> <562622CF.1070906@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <562622CF.1070906@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sylwester Nawrocki Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Andrzej Hajda , Kyungmin Park , Kukjin Kim , linux-clk@vger.kernel.org, Marek Szyprowski List-Id: devicetree@vger.kernel.org UXVvdGluZyBTeWx3ZXN0ZXIgTmF3cm9ja2kgKDIwMTUtMTAtMjAgMDQ6MTc6MzUpCj4gT24gMjAv MTAvMTUgMTI6MzQsIE1pY2hhZWwgVHVycXVldHRlIHdyb3RlOgo+ID4+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2R0LWJpbmRpbmdzL2Nsb2NrL2V4eW5vczU0MzMuaCBiL2luY2x1ZGUvZHQtYmluZGlu Z3MvY2xvY2svZXh5bm9zNTQzMy5oCj4gPj4gPiBpbmRleCA1YmQ4MGQ1Li40ZjBkNTY2IDEwMDY0 NAo+ID4+ID4gLS0tIGEvaW5jbHVkZS9kdC1iaW5kaW5ncy9jbG9jay9leHlub3M1NDMzLmgKPiA+ PiA+ICsrKyBiL2luY2x1ZGUvZHQtYmluZGluZ3MvY2xvY2svZXh5bm9zNTQzMy5oCj4gPj4gPiBA QCAtNzY1LDcgKzc2NSwxMCBAQAo+ID4+ID4gICNkZWZpbmUgQ0xLX1NDTEtfUkdCX1ZDTEsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAxMDkKPiA+PiA+ICAjZGVmaW5lIENMS19TQ0xLX1JH Ql9UVl9WQ0xLICAgICAgICAgICAgICAgICAgICAgICAgICAgMTEwCj4gPj4gPiAgCj4gPj4gPiAt I2RlZmluZSBESVNQX05SX0NMSyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDEx MQo+ID4+ID4gKyNkZWZpbmUgQ0xLX1BIWUNMS19IRE1JUEhZX1BJWEVMX0NMS09fUEhZICAgICAg ICAgICAgICAxMTEKPiA+PiA+ICsjZGVmaW5lIENMS19QSFlDTEtfSERNSVBIWV9UTURTX0NMS09f UEhZICAgICAgICAgICAgICAgMTEyCj4gPj4gPiArCj4gPj4gPiArI2RlZmluZSBESVNQX05SX0NM SyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDExMwo+ID4KPiA+IFdoeSBicmVh ayBjb21wYXRpYmlsaXR5IHdpdGggb2xkZXIgRFRCcz8KPiAKPiBJIHVzZWQgdG8gYmUgcmVzaXN0 YW50IHRvIGNoYW5naW5nIHRob3NlIF9OUl9DTEsgZGVmaW5lcwo+IGluIHRoZSBwYXN0IGJ1dCB0 aGVuIHJlYWxpemVkIHRoZXkgYXJlIG5vdCBwYXJ0IG9mIHRoZSBEVCBBQkkuCj4gVGhlc2UgZGVm aW5lcyBhcmUgdXNlZCBvbmx5IGluIGRyaXZlcnMgYW5kIGFmZmVjdCBvbmx5IHNpemUKPiBvZiB0 aGUgcHJvdmlkZXIncyBhbGxvY2F0ZWQgY2xvY2sgYXJyYXkuIFRoZSBjb25mdXNpb24gbWF5IGJl Cj4gY2F1c2VkIGJ5IHRoZSBmYWN0IHRoYXQgdGhlIHdob2xlIGhlYWRlciBpcyBzaGFyZWQgYnkg dGhlIGtlcm5lbAo+IHNvdXJjZSBhbmQgZHRzLgo+IAo+ICQgZ2l0IGdyZXAgLWwgX05SX0NMSyBh cmNoL2FybS9ib290L2R0cyBkcml2ZXJzL2Nsay9zYW1zdW5nLwo+IGRyaXZlcnMvY2xrL3NhbXN1 bmcvY2xrLWV4eW5vcy1jbGtvdXQuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4eW5vczMy NTAuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4eW5vczQuYwo+IGRyaXZlcnMvY2xrL3Nh bXN1bmcvY2xrLWV4eW5vczQ0MTUuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4eW5vczUy NTAuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4eW5vczUyNjAuYwo+IGRyaXZlcnMvY2xr L3NhbXN1bmcvY2xrLWV4eW5vczU0MTAuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4eW5v czU0MjAuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4eW5vczU0MzMuYwo+IGRyaXZlcnMv Y2xrL3NhbXN1bmcvY2xrLWV4eW5vczU0NDAuYwo+IGRyaXZlcnMvY2xrL3NhbXN1bmcvY2xrLWV4 eW5vczcuYwo+IAo+IFRoZXJlIGlzIG5vICpfTlJfQ0xLIGluIGFueSBkdHMgZmlsZS4KPiBOZXcg a2VybmVsIHdpbGwgd29yayB3aWxsIG9sZGVyIERUQiwgdGhlIGRyaXZlciB3aWxsIGp1c3QKPiBy ZWdpc3RlciBtb3JlIGNsb2Nrcywgd2hpY2ggd2lsbCBub3QgYmUgZGVyZWZlcmVuY2VkIGFueXdo ZXJlCj4gaW4gb2xkZXIgZHRiLgoKSSBza2ltbWVkIHRocm91Z2ggdGhlIGNvZGUgdG9vIGZhc3Qu IFlvdSdyZSByaWdodCwgaXRzIGEgc2VudGluZWwvbWF4CnZhbHVlIHRoaW5nIHdoaWNoIGlzIG5v dCBwYXJ0IG9mIHRoZSBBQkkuCgpQYXJkb24gdGhlIG5vaXNlLiBOb3RoaW5nIHRvIHNlZSBoZXJl LCBtb3ZlIGFsb25nLi4uCgpSZWdhcmRzLApNaWtlCgo+IAo+IC0tIAo+IFJlZ2FyZHMsCj4gU3ls d2VzdGVyCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGlu ZSAidW5zdWJzY3JpYmUgbGludXgtY2xrIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBt YWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDov L3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Sylwester Nawrocki , From: Michael Turquette In-Reply-To: <562622CF.1070906@samsung.com> Cc: "Andrzej Hajda" , "Inki Dae" , "Bartlomiej Zolnierkiewicz" , "Marek Szyprowski" , "Kyungmin Park" , dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, "Kukjin Kim" , "Krzysztof Kozlowski" , "Hyungwon Hwang" References: <1445332961-25419-1-git-send-email-a.hajda@samsung.com> <1445332961-25419-2-git-send-email-a.hajda@samsung.com> <20151020103416.20687.40409@quantum> <562622CF.1070906@samsung.com> Message-ID: <20151021085940.20687.94974@quantum> Subject: Re: [PATCH 01/10] clk/samsung: exynos5433: add definitions of HDMI-PHY output clocks Date: Wed, 21 Oct 2015 01:59:40 -0700 List-ID: Quoting Sylwester Nawrocki (2015-10-20 04:17:35) > On 20/10/15 12:34, Michael Turquette wrote: > >> diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindi= ngs/clock/exynos5433.h > >> > index 5bd80d5..4f0d566 100644 > >> > --- a/include/dt-bindings/clock/exynos5433.h > >> > +++ b/include/dt-bindings/clock/exynos5433.h > >> > @@ -765,7 +765,10 @@ > >> > #define CLK_SCLK_RGB_VCLK 109 > >> > #define CLK_SCLK_RGB_TV_VCLK 110 > >> > = > >> > -#define DISP_NR_CLK 111 > >> > +#define CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY 111 > >> > +#define CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY 112 > >> > + > >> > +#define DISP_NR_CLK 113 > > > > Why break compatibility with older DTBs? > = > I used to be resistant to changing those _NR_CLK defines > in the past but then realized they are not part of the DT ABI. > These defines are used only in drivers and affect only size > of the provider's allocated clock array. The confusion may be > caused by the fact that the whole header is shared by the kernel > source and dts. > = > $ git grep -l _NR_CLK arch/arm/boot/dts drivers/clk/samsung/ > drivers/clk/samsung/clk-exynos-clkout.c > drivers/clk/samsung/clk-exynos3250.c > drivers/clk/samsung/clk-exynos4.c > drivers/clk/samsung/clk-exynos4415.c > drivers/clk/samsung/clk-exynos5250.c > drivers/clk/samsung/clk-exynos5260.c > drivers/clk/samsung/clk-exynos5410.c > drivers/clk/samsung/clk-exynos5420.c > drivers/clk/samsung/clk-exynos5433.c > drivers/clk/samsung/clk-exynos5440.c > drivers/clk/samsung/clk-exynos7.c > = > There is no *_NR_CLK in any dts file. > New kernel will work will older DTB, the driver will just > register more clocks, which will not be dereferenced anywhere > in older dtb. I skimmed through the code too fast. You're right, its a sentinel/max value thing which is not part of the ABI. Pardon the noise. Nothing to see here, move along... Regards, Mike > = > -- = > Regards, > Sylwester > -- > To unsubscribe from this list: send the line "unsubscribe linux-clk" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html