From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/22] drm/i915: Pass modifier instead of tiling_mode to gen4_compute_page_offset() Date: Wed, 21 Oct 2015 11:54:00 +0200 Message-ID: <20151021095400.GT13786@phenom.ffwll.local> References: <1444840154-7804-1-git-send-email-ville.syrjala@linux.intel.com> <1444840154-7804-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 069546EDC3 for ; Wed, 21 Oct 2015 02:54:04 -0700 (PDT) Received: by wicfv8 with SMTP id fv8so66677143wic.0 for ; Wed, 21 Oct 2015 02:54:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1444840154-7804-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTQsIDIwMTUgYXQgMDc6Mjg6NTRQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBJbiBwcmVwYXJhdGlvbiBmb3IgaGFuZGxpbmcgbW9y ZSB0aGFuIFggdGlsaW5nLCBwYXNzIHRoZSBmYiBtb2RpZmllciB0bwo+IGdlbjRfY29tcHV0ZV9w YWdlX29mZnNldCgpIGluc3RlYWQgb2YgdGhlIG9iai0+dGlsaW5nX21vZGUuCj4gCj4gU2lnbmVk LW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K ClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgOCArKysrLS0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCA0ICsrLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgNiArKystLS0KPiAgMyBmaWxlcyBjaGFu Z2VkLCA5IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGMyOGZiNmEuLjZhZGQ4ZDEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTI0NDcsMTEgKzI0NDcsMTEgQEAgc3RhdGlj IHZvaWQgaW50ZWxfdW5waW5fZmJfb2JqKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAg KiBpcyBhc3N1bWVkIHRvIGJlIGEgcG93ZXItb2YtdHdvLiAqLwo+ICB1bnNpZ25lZCBsb25nIGlu dGVsX2dlbjRfY29tcHV0ZV9wYWdlX29mZnNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gIAkJCQkJICAgICBpbnQgKngsIGludCAqeSwKPiAtCQkJCQkgICAgIHVuc2lnbmVk IGludCB0aWxpbmdfbW9kZSwKPiArCQkJCQkgICAgIHVpbnQ2NF90IGZiX21vZGlmaWVyLAo+ICAJ CQkJCSAgICAgdW5zaWduZWQgaW50IGNwcCwKPiAgCQkJCQkgICAgIHVuc2lnbmVkIGludCBwaXRj aCkKPiAgewo+IC0JaWYgKHRpbGluZ19tb2RlICE9IEk5MTVfVElMSU5HX05PTkUpIHsKPiArCWlm IChmYl9tb2RpZmllciAhPSBEUk1fRk9STUFUX01PRF9OT05FKSB7Cj4gIAkJdW5zaWduZWQgaW50 IHRpbGVfcm93cywgdGlsZXM7Cj4gIAo+ICAJCXRpbGVfcm93cyA9ICp5IC8gODsKPiBAQCAtMjc1 NCw3ICsyNzU0LDcgQEAgc3RhdGljIHZvaWQgaTl4eF91cGRhdGVfcHJpbWFyeV9wbGFuZShzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4gIAlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gNCkgewo+ ICAJCWludGVsX2NydGMtPmRzcGFkZHJfb2Zmc2V0ID0KPiAgCQkJaW50ZWxfZ2VuNF9jb21wdXRl X3BhZ2Vfb2Zmc2V0KGRldl9wcml2LAo+IC0JCQkJCQkgICAgICAgJngsICZ5LCBvYmotPnRpbGlu Z19tb2RlLAo+ICsJCQkJCQkgICAgICAgJngsICZ5LCBmYi0+bW9kaWZpZXJbMF0sCj4gIAkJCQkJ CSAgICAgICBwaXhlbF9zaXplLAo+ICAJCQkJCQkgICAgICAgZmItPnBpdGNoZXNbMF0pOwo+ICAJ CWxpbmVhcl9vZmZzZXQgLT0gaW50ZWxfY3J0Yy0+ZHNwYWRkcl9vZmZzZXQ7Cj4gQEAgLTI4NTks NyArMjg1OSw3IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3VwZGF0ZV9wcmltYXJ5X3BsYW5lKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCWxpbmVhcl9vZmZzZXQgPSB5ICogZmItPnBpdGNoZXNb MF0gKyB4ICogcGl4ZWxfc2l6ZTsKPiAgCWludGVsX2NydGMtPmRzcGFkZHJfb2Zmc2V0ID0KPiAg CQlpbnRlbF9nZW40X2NvbXB1dGVfcGFnZV9vZmZzZXQoZGV2X3ByaXYsCj4gLQkJCQkJICAgICAg ICZ4LCAmeSwgb2JqLT50aWxpbmdfbW9kZSwKPiArCQkJCQkgICAgICAgJngsICZ5LCBmYi0+bW9k aWZpZXJbMF0sCj4gIAkJCQkJICAgICAgIHBpeGVsX3NpemUsCj4gIAkJCQkJICAgICAgIGZiLT5w aXRjaGVzWzBdKTsKPiAgCWxpbmVhcl9vZmZzZXQgLT0gaW50ZWxfY3J0Yy0+ZHNwYWRkcl9vZmZz ZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCAwNTk4OTMyLi4xMTUyNTY2IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTEzOCw4ICsxMTM4LDggQEAgdm9p ZCBhc3NlcnRfcGlwZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlw ZSBwaXBlLCBib29sIHN0YXRlKTsKPiAgI2RlZmluZSBhc3NlcnRfcGlwZV9kaXNhYmxlZChkLCBw KSBhc3NlcnRfcGlwZShkLCBwLCBmYWxzZSkKPiAgdW5zaWduZWQgbG9uZyBpbnRlbF9nZW40X2Nv bXB1dGVfcGFnZV9vZmZzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ CQkJCSAgICAgaW50ICp4LCBpbnQgKnksCj4gLQkJCQkJICAgICB1bnNpZ25lZCBpbnQgdGlsaW5n X21vZGUsCj4gLQkJCQkJICAgICB1bnNpZ25lZCBpbnQgYnBwLAo+ICsJCQkJCSAgICAgdWludDY0 X3QgZmJfbW9kaWZpZXIsCj4gKwkJCQkJICAgICB1bnNpZ25lZCBpbnQgY3BwLAo+ICAJCQkJCSAg ICAgdW5zaWduZWQgaW50IHBpdGNoKTsKPiAgdm9pZCBpbnRlbF9wcmVwYXJlX3Jlc2V0KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpOwo+ICB2b2lkIGludGVsX2ZpbmlzaF9yZXNldChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGIy MjljNjcuLjkwZTI3YzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBA IC00MjIsNyArNDIyLDcgQEAgdmx2X3VwZGF0ZV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpkcGxh bmUsIHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCWxpbmVhcl9vZmZzZXQgPSB5ICogZmItPnBp dGNoZXNbMF0gKyB4ICogcGl4ZWxfc2l6ZTsKPiAgCXNwcnN1cmZfb2Zmc2V0ID0gaW50ZWxfZ2Vu NF9jb21wdXRlX3BhZ2Vfb2Zmc2V0KGRldl9wcml2LAo+ICAJCQkJCQkJJngsICZ5LAo+IC0JCQkJ CQkJb2JqLT50aWxpbmdfbW9kZSwKPiArCQkJCQkJCWZiLT5tb2RpZmllclswXSwKPiAgCQkJCQkJ CXBpeGVsX3NpemUsCj4gIAkJCQkJCQlmYi0+cGl0Y2hlc1swXSk7Cj4gIAlsaW5lYXJfb2Zmc2V0 IC09IHNwcnN1cmZfb2Zmc2V0Owo+IEBAIC01NTYsNyArNTU2LDcgQEAgaXZiX3VwZGF0ZV9wbGFu ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwgc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJbGlu ZWFyX29mZnNldCA9IHkgKiBmYi0+cGl0Y2hlc1swXSArIHggKiBwaXhlbF9zaXplOwo+ICAJc3By c3VyZl9vZmZzZXQgPQo+ICAJCWludGVsX2dlbjRfY29tcHV0ZV9wYWdlX29mZnNldChkZXZfcHJp diwKPiAtCQkJCQkgICAgICAgJngsICZ5LCBvYmotPnRpbGluZ19tb2RlLAo+ICsJCQkJCSAgICAg ICAmeCwgJnksIGZiLT5tb2RpZmllclswXSwKPiAgCQkJCQkgICAgICAgcGl4ZWxfc2l6ZSwgZmIt PnBpdGNoZXNbMF0pOwo+ICAJbGluZWFyX29mZnNldCAtPSBzcHJzdXJmX29mZnNldDsKPiAgCj4g QEAgLTY5NCw3ICs2OTQsNyBAQCBpbGtfdXBkYXRlX3BsYW5lKHN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lLCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAlsaW5lYXJfb2Zmc2V0ID0geSAqIGZiLT5w aXRjaGVzWzBdICsgeCAqIHBpeGVsX3NpemU7Cj4gIAlkdnNzdXJmX29mZnNldCA9Cj4gIAkJaW50 ZWxfZ2VuNF9jb21wdXRlX3BhZ2Vfb2Zmc2V0KGRldl9wcml2LAo+IC0JCQkJCSAgICAgICAmeCwg JnksIG9iai0+dGlsaW5nX21vZGUsCj4gKwkJCQkJICAgICAgICZ4LCAmeSwgZmItPm1vZGlmaWVy WzBdLAo+ICAJCQkJCSAgICAgICBwaXhlbF9zaXplLCBmYi0+cGl0Y2hlc1swXSk7Cj4gIAlsaW5l YXJfb2Zmc2V0IC09IGR2c3N1cmZfb2Zmc2V0Owo+ICAKPiAtLSAKPiAyLjQuOQo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK