From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 13/22] drm/i915: Move the partial and rotated view data into the same union Date: Wed, 21 Oct 2015 13:30:22 +0200 Message-ID: <20151021113022.GE13786@phenom.ffwll.local> References: <1444840154-7804-1-git-send-email-ville.syrjala@linux.intel.com> <1444840154-7804-14-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEE3A6EDCB for ; Wed, 21 Oct 2015 04:30:25 -0700 (PDT) Received: by wicll6 with SMTP id ll6so69638638wic.1 for ; Wed, 21 Oct 2015 04:30:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1444840154-7804-14-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTQsIDIwMTUgYXQgMDc6Mjk6MDVQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBFYWNoIGd0dCB2aWV3IG9ubHkgaGFzIGEgc2luZ2xl IHR5cGUsIGFuZCBzbyBkb24ndCBuZWVkIHRvIGNvbnRhaW4gZGF0YQo+IGZvciBib3RoIHJvdGF0 ZWQgYW5kIHBhcnRpYWwgdmlld3MuIFNvIHdlIGNhbiBtb3ZlIHRoZSBkYXRhIGludG8gdGhlCj4g c2FtZSB1bmlvbiB0byBhdm9pZCB3YXN0aW5nIHNwYWNlLgo+IAo+IEFsc28gcmVuYW1lICdyb3Rh dGlvbl9pbmZvJyB0byAncm90YXRlZCcgdG8gbWF0Y2ggdGhlIHZpZXcgdHlwZSBleGFjdGx5LAo+ IHRoaXMgc2hvdWxkIGF2b2lkIGNvbmZ1c2lvbiB3aGljaCB1bmlvbiBtZW1iZXJzIGlzIHZhbGlk IGZvciBlYWNoIHZpZXcKPiB0eXBlLiBBbHNvIG1ha2UgdGhlIHVuaW9uIGFub255bW91cyB0byBh dm9pZCB0aGUgLnBhcmFtcy4gc3R1ZmYgYWxsCj4gb3Zlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgfCAxMCArKysrKy0tLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jICB8IDEyICsrKysrKy0tLS0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaCAgfCAxMSArKysrLS0tLS0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAgNCArKy0tCj4gIDQgZmlsZXMg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jCj4gaW5kZXggZTU3MDYxYS4uYjkzZWQxOCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+IEBAIC0xNzcyLDEyICsxNzcyLDEyIEBAIGludCBpOTE1X2dlbV9mYXVsdChz dHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgc3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4gIAo+ICAJ CW1lbXNldCgmdmlldywgMCwgc2l6ZW9mKHZpZXcpKTsKPiAgCQl2aWV3LnR5cGUgPSBJOTE1X0dH VFRfVklFV19QQVJUSUFMOwo+IC0JCXZpZXcucGFyYW1zLnBhcnRpYWwub2Zmc2V0ID0gcm91bmRk b3duKHBhZ2Vfb2Zmc2V0LCBjaHVua19zaXplKTsKPiAtCQl2aWV3LnBhcmFtcy5wYXJ0aWFsLnNp emUgPQo+ICsJCXZpZXcucGFydGlhbC5vZmZzZXQgPSByb3VuZGRvd24ocGFnZV9vZmZzZXQsIGNo dW5rX3NpemUpOwo+ICsJCXZpZXcucGFydGlhbC5zaXplID0KPiAgCQkJbWluX3QodW5zaWduZWQg aW50LAo+ICAJCQkgICAgICBjaHVua19zaXplLAo+ICAJCQkgICAgICAodm1hLT52bV9lbmQgLSB2 bWEtPnZtX3N0YXJ0KS9QQUdFX1NJWkUgLQo+IC0JCQkgICAgICB2aWV3LnBhcmFtcy5wYXJ0aWFs Lm9mZnNldCk7Cj4gKwkJCSAgICAgIHZpZXcucGFydGlhbC5vZmZzZXQpOwo+ICAJfQo+ICAKPiAg CS8qIE5vdyBwaW4gaXQgaW50byB0aGUgR1RUIGlmIG5lZWRlZCAqLwo+IEBAIC0xODA1LDEwICsx ODA1LDEwIEBAIGludCBpOTE1X2dlbV9mYXVsdChzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwg c3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4gIAkJICogaGF2aW5nIGFjY2Vzc2VkIGl0IGJlZm9yZSAo YXQgdGhpcyBwYXJ0aWFscycgcmFuZ2UpLgo+ICAJCSAqLwo+ICAJCXVuc2lnbmVkIGxvbmcgYmFz ZSA9IHZtYS0+dm1fc3RhcnQgKwo+IC0JCQkJICAgICAodmlldy5wYXJhbXMucGFydGlhbC5vZmZz ZXQgPDwgUEFHRV9TSElGVCk7Cj4gKwkJCQkgICAgICh2aWV3LnBhcnRpYWwub2Zmc2V0IDw8IFBB R0VfU0hJRlQpOwo+ICAJCXVuc2lnbmVkIGludCBpOwo+ICAKPiAtCQlmb3IgKGkgPSAwOyBpIDwg dmlldy5wYXJhbXMucGFydGlhbC5zaXplOyBpKyspIHsKPiArCQlmb3IgKGkgPSAwOyBpIDwgdmll dy5wYXJ0aWFsLnNpemU7IGkrKykgewo+ICAJCQlyZXQgPSB2bV9pbnNlcnRfcGZuKHZtYSwgYmFz ZSArIGkgKiBQQUdFX1NJWkUsIHBmbiArIGkpOwo+ICAJCQlpZiAocmV0KQo+ICAJCQkJYnJlYWs7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCA3MWFjYzcxLi5lMGJhZmYy IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtMzI4Miw3ICszMjgy LDcgQEAgc3RhdGljIHN0cnVjdCBzZ190YWJsZSAqCj4gIGludGVsX3JvdGF0ZV9mYl9vYmpfcGFn ZXMoc3RydWN0IGk5MTVfZ2d0dF92aWV3ICpnZ3R0X3ZpZXcsCj4gIAkJCSAgc3RydWN0IGRybV9p OTE1X2dlbV9vYmplY3QgKm9iaikKPiAgewo+IC0Jc3RydWN0IGludGVsX3JvdGF0aW9uX2luZm8g KnJvdF9pbmZvID0gJmdndHRfdmlldy0+cm90YXRpb25faW5mbzsKPiArCXN0cnVjdCBpbnRlbF9y b3RhdGlvbl9pbmZvICpyb3RfaW5mbyA9ICZnZ3R0X3ZpZXctPnJvdGF0ZWQ7Cj4gIAl1bnNpZ25l ZCBpbnQgc2l6ZV9wYWdlcyA9IHJvdF9pbmZvLT5zaXplID4+IFBBR0VfU0hJRlQ7Cj4gIAl1bnNp Z25lZCBpbnQgc2l6ZV9wYWdlc191djsKPiAgCXN0cnVjdCBzZ19wYWdlX2l0ZXIgc2dfaXRlcjsK PiBAQCAtMzM4MCwxNiArMzM4MCwxNiBAQCBpbnRlbF9wYXJ0aWFsX3BhZ2VzKGNvbnN0IHN0cnVj dCBpOTE1X2dndHRfdmlldyAqdmlldywKPiAgCWlmICghc3QpCj4gIAkJZ290byBlcnJfc3RfYWxs b2M7Cj4gIAo+IC0JcmV0ID0gc2dfYWxsb2NfdGFibGUoc3QsIHZpZXctPnBhcmFtcy5wYXJ0aWFs LnNpemUsIEdGUF9LRVJORUwpOwo+ICsJcmV0ID0gc2dfYWxsb2NfdGFibGUoc3QsIHZpZXctPnBh cnRpYWwuc2l6ZSwgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gZXJyX3NnX2Fs bG9jOwo+ICAKPiAgCXNnID0gc3QtPnNnbDsKPiAgCXN0LT5uZW50cyA9IDA7Cj4gIAlmb3JfZWFj aF9zZ19wYWdlKG9iai0+cGFnZXMtPnNnbCwgJm9ial9zZ19pdGVyLCBvYmotPnBhZ2VzLT5uZW50 cywKPiAtCQl2aWV3LT5wYXJhbXMucGFydGlhbC5vZmZzZXQpCj4gKwkJdmlldy0+cGFydGlhbC5v ZmZzZXQpCj4gIAl7Cj4gLQkJaWYgKHN0LT5uZW50cyA+PSB2aWV3LT5wYXJhbXMucGFydGlhbC5z aXplKQo+ICsJCWlmIChzdC0+bmVudHMgPj0gdmlldy0+cGFydGlhbC5zaXplKQo+ICAJCQlicmVh azsKPiAgCj4gIAkJc2dfc2V0X3BhZ2Uoc2csIE5VTEwsIFBBR0VfU0laRSwgMCk7Cj4gQEAgLTM1 MTQsOSArMzUxNCw5IEBAIGk5MTVfZ2d0dF92aWV3X3NpemUoc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKm9iaiwKPiAgCWlmICh2aWV3LT50eXBlID09IEk5MTVfR0dUVF9WSUVXX05PUk1BTCkg ewo+ICAJCXJldHVybiBvYmotPmJhc2Uuc2l6ZTsKPiAgCX0gZWxzZSBpZiAodmlldy0+dHlwZSA9 PSBJOTE1X0dHVFRfVklFV19ST1RBVEVEKSB7Cj4gLQkJcmV0dXJuIHZpZXctPnJvdGF0aW9uX2lu Zm8uc2l6ZTsKPiArCQlyZXR1cm4gdmlldy0+cm90YXRlZC5zaXplOwo+ICAJfSBlbHNlIGlmICh2 aWV3LT50eXBlID09IEk5MTVfR0dUVF9WSUVXX1BBUlRJQUwpIHsKPiAtCQlyZXR1cm4gdmlldy0+ cGFyYW1zLnBhcnRpYWwuc2l6ZSA8PCBQQUdFX1NISUZUOwo+ICsJCXJldHVybiB2aWV3LT5wYXJ0 aWFsLnNpemUgPDwgUEFHRV9TSElGVDsKPiAgCX0gZWxzZSB7Cj4gIAkJV0FSTl9PTkNFKDEsICJH R1RUIHZpZXcgJXUgbm90IGltcGxlbWVudGVkIVxuIiwgdmlldy0+dHlwZSk7Cj4gIAkJcmV0dXJu IG9iai0+YmFzZS5zaXplOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4gaW5kZXgg YTIxNjM5Ny4uY2FhMTgyZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4g QEAgLTE1MSwxNyArMTUxLDE0IEBAIHN0cnVjdCBpbnRlbF9yb3RhdGlvbl9pbmZvIHsKPiAgc3Ry dWN0IGk5MTVfZ2d0dF92aWV3IHsKPiAgCWVudW0gaTkxNV9nZ3R0X3ZpZXdfdHlwZSB0eXBlOwo+ ICAKPiArCXN0cnVjdCBzZ190YWJsZSAqcGFnZXM7Cj4gKwo+ICAJdW5pb24gewo+ICsJCXN0cnVj dCBpbnRlbF9yb3RhdGlvbl9pbmZvIHJvdGF0ZWQ7Cj4gIAkJc3RydWN0IHsKPiAgCQkJdTY0IG9m ZnNldDsKPiAgCQkJdW5zaWduZWQgaW50IHNpemU7Cj4gIAkJfSBwYXJ0aWFsOwo+IC0JfSBwYXJh bXM7CgpJZiB5b3Uga2VlcCB0aGUgbmFtZSBmb3IgdGhpcyB1bmlvbiAodG8gZnV0dXJlLXByb29m IHRoZSBuZXh0IHBhdGNoKToKCkFja2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgoKYWthIEkgdHJ1c3QgeW91ciBjb21waWxlciB0byBnZXQgdGhpcyByaWdodCA7 LSkKCkNoZWVycywgRGFuaWVsCgo+IC0KPiAtCXN0cnVjdCBzZ190YWJsZSAqcGFnZXM7Cj4gLQo+ IC0JdW5pb24gewo+IC0JCXN0cnVjdCBpbnRlbF9yb3RhdGlvbl9pbmZvIHJvdGF0aW9uX2luZm87 Cj4gIAl9Owo+ICB9Owo+ICAKPiBAQCAtNTU3LDcgKzU1NCw3IEBAIGk5MTVfZ2d0dF92aWV3X2Vx dWFsKGNvbnN0IHN0cnVjdCBpOTE1X2dndHRfdmlldyAqYSwKPiAgCWlmIChhLT50eXBlICE9IGIt PnR5cGUpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJaWYgKGEtPnR5cGUgPT0gSTkxNV9HR1RUX1ZJ RVdfUEFSVElBTCkKPiAtCQlyZXR1cm4gIW1lbWNtcCgmYS0+cGFyYW1zLCAmYi0+cGFyYW1zLCBz aXplb2YoYS0+cGFyYW1zKSk7Cj4gKwkJcmV0dXJuICFtZW1jbXAoJmEtPnBhcnRpYWwsICZiLT5w YXJ0aWFsLCBzaXplb2YoYS0+cGFydGlhbCkpOwo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiAgCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDgwZTlmMmUuLmNlMzQ2Y2Zl IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0yMjgwLDcgKzIy ODAsNyBAQCBpbnRlbF9maWxsX2ZiX2dndHRfdmlldyhzdHJ1Y3QgaTkxNV9nZ3R0X3ZpZXcgKnZp ZXcsCj4gIAkJCXVuc2lnbmVkIGludCByb3RhdGlvbikKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShmYi0+ZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9y b3RhdGlvbl9pbmZvICppbmZvID0gJnZpZXctPnJvdGF0aW9uX2luZm87Cj4gKwlzdHJ1Y3QgaW50 ZWxfcm90YXRpb25faW5mbyAqaW5mbyA9ICZ2aWV3LT5yb3RhdGVkOwo+ICAJdW5zaWduZWQgaW50 IHRpbGVfc2l6ZSwgdGlsZV93aWR0aCwgdGlsZV9oZWlnaHQsIGNwcDsKPiAgCj4gIAkqdmlldyA9 IGk5MTVfZ2d0dF92aWV3X25vcm1hbDsKPiBAQCAtMzAyMCw3ICszMDIwLDcgQEAgdW5zaWduZWQg bG9uZyBpbnRlbF9wbGFuZV9vYmpfb2Zmc2V0KHN0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxh bmUsCj4gIAlvZmZzZXQgPSAodW5zaWduZWQgY2hhciAqKXZtYS0+bm9kZS5zdGFydDsKPiAgCj4g IAlpZiAocGxhbmUgPT0gMSkgewo+IC0JCW9mZnNldCArPSB2bWEtPmdndHRfdmlldy5yb3RhdGlv bl9pbmZvLnV2X3N0YXJ0X3BhZ2UgKgo+ICsJCW9mZnNldCArPSB2bWEtPmdndHRfdmlldy5yb3Rh dGVkLnV2X3N0YXJ0X3BhZ2UgKgo+ICAJCQkgIFBBR0VfU0laRTsKPiAgCX0KPiAgCj4gLS0gCj4g Mi40LjkKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==