From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZotrO-0001h9-2g
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:55:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZotrN-00037S-BS
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:55:22 -0400
Date: Wed, 21 Oct 2015 14:55:09 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20151021135509.GH13408@stefanha-thinkpad.redhat.com>
References: <1443130823-10723-1-git-send-email-jsnow@redhat.com>
	<5626A198.8040208@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5626A198.8040208@redhat.com>
Subject: Re: [Qemu-devel] [RFC] transactions: add transaction-wide property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: famz@redhat.com, armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org

Thanks for summarizing the discussion!

If you are taking over Fam's series, please squash in your patches to
make review easier.

Maybe the names can be improved:

"allow-partial" is not self-explanatory.

"sync-cancel" is misleading since successful completion is affected too,
not just failure/cancel (jobs wait for each other before reporting
successful completion).

How about "transactional-completion" or "group-completion": "none"/"all"?

Stefan