From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZovDL-0004d8-TO
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 11:22:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZovDG-0007WS-P7
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 11:22:07 -0400
Date: Wed, 21 Oct 2015 11:21:45 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20151021152145.GB6466@localhost.localdomain>
References: <1445393209-26545-1-git-send-email-famz@redhat.com>
	<1445393209-26545-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445393209-26545-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 02/12] nbd: Mark fd
 handlers client type as "external"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Oct 21, 2015 at 10:06:39AM +0800, Fam Zheng wrote:
> So we could distinguish it from internal used fds, thus avoid handling
> unwanted events in nested aio polls.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  nbd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/nbd.c b/nbd.c
> index fbc66be..dab1ebb 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1446,7 +1446,7 @@ static void nbd_set_handlers(NBDClient *client)
>  {
>      if (client->exp && client->exp->ctx) {
>          aio_set_fd_handler(client->exp->ctx, client->sock,
> -                           false,
> +                           true,
>                             client->can_read ? nbd_read : NULL,
>                             client->send_coroutine ? nbd_restart_write : NULL,
>                             client);
> @@ -1457,7 +1457,7 @@ static void nbd_unset_handlers(NBDClient *client)
>  {
>      if (client->exp && client->exp->ctx) {
>          aio_set_fd_handler(client->exp->ctx, client->sock,
> -                           false, NULL, NULL, NULL);
> +                           true, NULL, NULL, NULL);
>      }
>  }
>  
> -- 
> 2.4.3
> 
> 

Reviewed-by: Jeff Cody <jcody@redhat.com>