From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zp9sY-0005tr-KG for qemu-devel@nongnu.org; Thu, 22 Oct 2015 03:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zp9sU-0000AZ-Ju for qemu-devel@nongnu.org; Thu, 22 Oct 2015 03:01:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zp9sU-0000AS-F1 for qemu-devel@nongnu.org; Thu, 22 Oct 2015 03:01:34 -0400 Date: Thu, 22 Oct 2015 09:03:07 +0200 From: Peter Krempa Message-ID: <20151022070307.GA5667@andariel.pipo.sk> References: <1445434451-3439-1-git-send-email-prasanna.kalever@redhat.com> <1445434451-3439-3-git-send-email-prasanna.kalever@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline In-Reply-To: <1445434451-3439-3-git-send-email-prasanna.kalever@redhat.com> Subject: Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 21, 2015 at 19:04:11 +0530, Prasanna Kumar Kalever wrote: =2E.. > --- > block/gluster.c | 420 +++++++++++++++++++++++++++++++++++++++++++++= ------ > qapi/block-core.json | 62 +++++++- > 2 files changed, 433 insertions(+), 49 deletions(-) >=20 > diff --git a/block/gluster.c b/block/gluster.c > index ededda2..62b6656 100644 > --- a/block/gluster.c > +++ b/block/gluster.c =2E.. > + > =20 > static void qemu_gluster_gconf_free(GlusterConf *gconf) > { > if (gconf) { > - g_free(gconf->host); > g_free(gconf->volume); > g_free(gconf->path); > - g_free(gconf->transport); > + if (gconf->gsconf) { > + g_free(gconf->gsconf[0].host); > + g_free(gconf->gsconf[0].transport); > + g_free(gconf->gsconf); Looks like this leaks second and any further server config struct. > + } > g_free(gconf); > } > } Peter --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJWKIorAAoJEDbsFqzQGGgr7BQP/1f0l0gCkBNLnd2iC0CXAiv5 ASnpApln0bOYuMQMiZE8dPYtnQY55iXkVj3M30mhY0YpsV7EOGCVtkstkV/5lFV8 TpiT02irCndvsVCyie+KyAv3u9GrGWyVpk4/+3yK60SZn1QaKW8P25vjIGYMRz0v 2ePiNpjfHOaTvSNEI2c7etCwJ80g8191f3xwq86zsn+q2ck2o77TrjuhchuSsuhu XcDwenjqhjr8IZP4fJZ/p+TpPt0+1BVKl27I/Z3OM999dHS1cP/bd9z0j8a/xrFF 6WvDzWuQi6eTENMAhkAR7NrZLKWxJPGmwZG6j6wTC6o5ilaJBtPgpeiXLpkOB3aS bFpLKPosZLjYLlTAmFRI5SDPj2CBN5XcYaYx8qc5fHVZxr8HNPIJXwKAS/hv+nHc eF+nR8q749T0qvtfsmyr/LPVZyfA0MNMyq/nTiBPtdn/ZjWo93JS/OSges5wrdgj O5C5HpnEpiE4e2GQPNDk2nsWmjNeXwmnc6bRVPEjTLhelNWrOUxCsfB6ghRsF6Xi 8QsdStGyikQMO66M6YHA0CDsn4nGNKg/xWzlADkvAr+K0sYEgVNvsNIcMqeoQFHA F6Dd3syqqttQONganDDtkKfprn4d43HSfQKnyb8EsQQE2eLz5HLD3RNAWKg3lSyr W1xVQEzyunzjSQvmLAw+ =tH7a -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm--