From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756904AbbJVIXM (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Oct 2015 04:23:12 -0400
Received: from mail-wi0-f170.google.com ([209.85.212.170]:36457 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750993AbbJVIXG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Oct 2015 04:23:06 -0400
Date: Thu, 22 Oct 2015 10:23:01 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        Chandler Carruth <chandlerc@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [PATCH 2/3] perf top: Support call-graph display options also
Message-ID: <20151022082301.GB18916@gmail.com>
References: <1445495330-25416-1-git-send-email-namhyung@kernel.org>
 <1445495330-25416-2-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445495330-25416-2-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Namhyung Kim <namhyung@kernel.org> wrote:

> Currently 'perf top --call-graph' option is same as 'perf record'.  But
> 'perf top' also need to receive display options in 'perf report'.  To do
> that, change parse_callchain_report_opt() to allow record options too.
> 
> Now perf top can receive display options like below:
> 
>   $ perf top --call-graph
>     Error: option `call-graph' requires a value
> 
>    Usage: perf top [<options>]
> 
>         --call-graph
>           <mode[,dump_size],output_type,min_percent[,print_limit],call_order[,branch]>
>                      setup and enables call-graph (stack chain/backtrace)
>                      recording: fp dwarf lbr, output_type (graph, flat,
> 		     fractal, or none), min percent threshold, optional
> 		     print limit, callchain order, key (function or
> 		     address), add branches

Yeah, so this fix is nice, and I think we should also do another patch to fix the 
help text output to be the following:

         --call-graph
           <record_mode[,record_size],print_style,limit[,print_limit],call_order[,sort_key]>

              Set up and enable call graph (call chain, stack backtrace) recording:

                 record_mode:   call graph recording mode (fp|dwarf|lbr)
                 record_size:   if rec_mode == dwarf, maximum depth of stack recording (bytes),
                                default: 8192 bytes.
                 print_style:   call graph printing style (graph|flat|fractal|none)
                 limit:         minimum call graph inclusion threshold (percent)
                 print_limit:   printing threshold (percent)
                 call_order:    call graph order (caller|callee)
                 sort_key:      sorting key (function|address|branch)

               Default: fp,graph,0.5,0.0,caller,function

Note that this text evolved a bit over what I sent in my previous mail.

Also note that I think we should sync up the perf config options to be the same as 
the option name shortcuts used in this help text.

Side note: to improve perf config usability, we should probably also recognize 
underscores in perf config entries, i.e. the following variants should both work:

	print_percent = 1
	print-percent = 1

Right now only the second one will match.

Thanks,

	Ingo