From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757361AbbJVMVJ (ORCPT ); Thu, 22 Oct 2015 08:21:09 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:38879 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964849AbbJVMVE (ORCPT ); Thu, 22 Oct 2015 08:21:04 -0400 Date: Thu, 22 Oct 2015 14:21:03 +0200 From: Frederic Weisbecker To: Namhyung Kim Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Adrian Hunter , Borislav Petkov , Brendan Gregg , Chandler Carruth , Stephane Eranian , Wang Nan Subject: Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled Message-ID: <20151022122101.GB26217@lerouge> References: <1445495330-25416-1-git-send-email-namhyung@kernel.org> <1445495330-25416-3-git-send-email-namhyung@kernel.org> <20151022073247.GA14234@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2015 at 04:38:44PM +0900, Namhyung Kim wrote: > Hi Ingo, > > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: > > > > * Namhyung Kim wrote: > > > >> The caller callchain order is useful with --children option since it can > >> show 'overview' style output, but other commands which don't use > >> --children feature like 'perf script' or even 'perf report/top' without > >> --children are better to keep caller order. > > Oops, there's a typo: s/caller order/callee order/ :) Oops, didn't see that reply. Thanks! Acked-by: Frederic Weisbecker