From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757488AbbJVNIz (ORCPT ); Thu, 22 Oct 2015 09:08:55 -0400 Received: from sauhun.de ([89.238.76.85]:58516 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbbJVNIy (ORCPT ); Thu, 22 Oct 2015 09:08:54 -0400 Date: Thu, 22 Oct 2015 15:08:47 +0200 From: Wolfram Sang To: Ludovic Desroches Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com, peda@lysator.liu.se, cyrille.pitchen@atmel.com Subject: Re: [PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer Message-ID: <20151022130847.GE1517@katana> References: <1445435048-25889-1-git-send-email-ludovic.desroches@atmel.com> <1445435048-25889-2-git-send-email-ludovic.desroches@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d8Lz2Tf5e5STOWUP" Content-Disposition: inline In-Reply-To: <1445435048-25889-2-git-send-email-ludovic.desroches@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --d8Lz2Tf5e5STOWUP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 21, 2015 at 03:44:04PM +0200, Ludovic Desroches wrote: > In some cases, we could start a new i2c transfer with the RXRDY flag > set. It is not a clean state and it leads to print annoying error > messages even if there no real issue. The cause is only having garbage > data in the Receive Holding Register because of a weird behavior of the > RXRDY flag. >=20 > Signed-off-by: Ludovic Desroches > Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA > controller") > Reported-by: Peter Rosin > Tested-by: Peter Rosin > Cc: stable@vger.kernel.org #4.1 SMATCH drivers/i2c/busses/i2c-at91.c:602 at91_do_twi_transfer warn: unused return:= sr =3D at91_twi_read() drivers/i2c/busses/i2c-at91.c: In function 'at91_do_twi_transfer': drivers/i2c/busses/i2c-at91.c:550:11: warning: variable 'sr' set but not us= ed [-Wunused-but-set-variable] unsigned sr; ^ --d8Lz2Tf5e5STOWUP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWKN/fAAoJEBQN5MwUoCm2qcsP/3xR/eLcoYMI49N8BReGCV4a FMUXvwHz2nTlwNE24628gjVLPj7Mwj5Vou0qobN2voCdsB+q3FU2OuArznmKnAxG Bb2b+H1bsPUrIgXa/wGGgBojm6tEovkkyl7KecFXZXMPGf5RDQQ2OzN25C3PK4JL jX9aS3+KbjWNh3hB3ba6U8QVAWbuPN2T+xHZ4pnmmOOMdwdYwEYG9KpbiPARSzcF UXT3hY8/1hzorjI64MrcfExxN1bOi+uFCmnsZG8KUB85UXGwdBRLIlig8aFtT9Gn EfpOGp6qNqCVSJe6E79PHr5ArCJq94Sr3ydc1piuBE26u9qqx7MD8Ve+INVonUvW RB4zefNwmCbtxU8W/1OSdVGrraJwCc/m63lcTtatMhRExxSQdzSPXdHot/zVWCA1 bePyn+hFbP5qx1CgJlrTCVuNtHRqt5LHYRff5NinHmittnPiMLKApNndiuRKbrie v8LQA4ANv5YapGeOMSfNl8INVC0oGd2yqovvCCDh0F+s9YlBuOjZQJf1mU2o13Q4 tVZG5Wce0g0yTkIF5ULLs8cYke5CB8YbJLVrAQOtPWMEIuk5GkwUjj9UDDejBsPm t/PijqxvFVxCM26ycpEz/3PwC3kldvDZOHQs3SglQcLtSuvIHuV8/ukMv1l9F/HP KUHZHhprGqHWPeqXW7CX =OYhx -----END PGP SIGNATURE----- --d8Lz2Tf5e5STOWUP-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa@the-dreams.de (Wolfram Sang) Date: Thu, 22 Oct 2015 15:08:47 +0200 Subject: [PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer In-Reply-To: <1445435048-25889-2-git-send-email-ludovic.desroches@atmel.com> References: <1445435048-25889-1-git-send-email-ludovic.desroches@atmel.com> <1445435048-25889-2-git-send-email-ludovic.desroches@atmel.com> Message-ID: <20151022130847.GE1517@katana> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 21, 2015 at 03:44:04PM +0200, Ludovic Desroches wrote: > In some cases, we could start a new i2c transfer with the RXRDY flag > set. It is not a clean state and it leads to print annoying error > messages even if there no real issue. The cause is only having garbage > data in the Receive Holding Register because of a weird behavior of the > RXRDY flag. > > Signed-off-by: Ludovic Desroches > Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA > controller") > Reported-by: Peter Rosin > Tested-by: Peter Rosin > Cc: stable at vger.kernel.org #4.1 SMATCH drivers/i2c/busses/i2c-at91.c:602 at91_do_twi_transfer warn: unused return: sr = at91_twi_read() drivers/i2c/busses/i2c-at91.c: In function 'at91_do_twi_transfer': drivers/i2c/busses/i2c-at91.c:550:11: warning: variable 'sr' set but not used [-Wunused-but-set-variable] unsigned sr; ^ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: