All of
 help / color / mirror / Atom feed
From: Greg Kurz <>
Cc:, "Michael S. Tsirkin" <>
Subject: [Qemu-devel] [PATCH] virtio-9p: add savem handlers
Date: Thu, 22 Oct 2015 19:38:42 +0200	[thread overview]
Message-ID: <> (raw)

We don't support migration of mounted 9p shares. This is handled by a
migration blocker.

One would expect, however, to be able to migrate if the share is unmounted.
Unfortunately virtio-9p-device does not register savevm handlers at all !
Migration succeeds and leaves the guest with a dangling device...

This patch simply registers migration handlers for virtio-9p-device. Whether
migration is possible or not still depends on the migration blocker.

Signed-off-by: Greg Kurz <>
Michael, Aneesh,

This is the same patch minus the call to unregister_savevm() since we don't
have an unrealize handler.

I decided to simply drop all the other patches. Hot-unplug support is totally
missing and definitely needs more work. I'll try to come up with a solution
in its own series.



 hw/9pfs/virtio-9p-device.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 93a407c45926..e3abcfaffb2a 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -43,6 +43,16 @@ static void virtio_9p_get_config(VirtIODevice *vdev, uint8_t *config)
+static void virtio_9p_save(QEMUFile *f, void *opaque)
+    virtio_save(VIRTIO_DEVICE(opaque), f);
+static int virtio_9p_load(QEMUFile *f, void *opaque, int version_id)
+    return virtio_load(VIRTIO_DEVICE(opaque), f, version_id);
 static void virtio_9p_device_realize(DeviceState *dev, Error **errp)
     VirtIODevice *vdev = VIRTIO_DEVICE(dev);
@@ -130,6 +140,7 @@ static void virtio_9p_device_realize(DeviceState *dev, Error **errp)
+    register_savevm(dev, "virtio-9p", -1, 1, virtio_9p_save, virtio_9p_load, s);

             reply	other threads:[~2015-10-22 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 17:38 Greg Kurz [this message]
2015-11-12  8:28 ` [Qemu-devel] [PATCH] virtio-9p: add savem handlers Greg Kurz
2015-11-12 12:50   ` Cornelia Huck
2015-11-12 14:25     ` Greg Kurz
2015-11-12 14:39       ` Cornelia Huck
2015-11-12 16:06         ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.