From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbbJWGFu (ORCPT ); Fri, 23 Oct 2015 02:05:50 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59334 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750758AbbJWGFs (ORCPT ); Fri, 23 Oct 2015 02:05:48 -0400 Date: Fri, 23 Oct 2015 08:05:45 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Hans de Goede , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Brown Subject: Re: [PATCH v4 0/4] simplefb: Add regulator handling support Message-ID: <20151023060545.GE10947@lukather> References: <1445572241-13259-1-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tpXFRyzAyQ/GSAaD" Content-Disposition: inline In-Reply-To: <1445572241-13259-1-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tpXFRyzAyQ/GSAaD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 23, 2015 at 11:50:37AM +0800, Chen-Yu Tsai wrote: > Hi everyone, >=20 > This is v4 of the simplefb regulator support series. This series adds > regulator claiming and enabling support for simplefb. >=20 > Changes since v4: > - Fixed inverted logic when testing the property name. > - Fixed regulator supply name string copy length off by 1. > - Added real world user, MSI Primo 81 dts patches. >=20 > Changes since v3: > - Dropped extra "if" which is always true, leftover from v1. > - Updated commit message of patch 1 >=20 > Sometimes the simplefb display output path consits of external conversion > chips and/or LCD drivers and backlights. These devices normally have > GPIOs to turn them on and/or bring them out of reset, and regulators > supplying power to them. >=20 > While the kernel does not touch unclaimed GPIOs, the regulator core > happily disables unused regulators. Thus we need simplefb to claim > and enable the regulators used throughout the display pipeline. >=20 > The binding supports any named regulator supplies under its device > node. The driver will look through its properties, and claim any > regulators by matching "*-supply", as Mark suggested. >=20 > I've not done a generic helper in the regulator core yet, instead doing > the regulator property handling in the simplefb code for now. >=20 >=20 > Patch 1 adds the regulator properties to the DT binding. >=20 > Patch 2 adds code to the simplefb driver to claim and enable regulators. > Hans, I dropped your Reviewed-by tag from this patch. >=20 > Patch 3 adds labels to the simplefb device nodes in sun6i-a31.dtsi > so we can reference them in the board dts files, like in the next > patch. >=20 > Patch 4 adds a dts file for MSI's Primo 81 tablet. Applied 3 and 4. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --tpXFRyzAyQ/GSAaD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWKc45AAoJEBx+YmzsjxAguikP/1rkc7+H/3E0XZTRo1GqEERc iOdaJKIEhRD/OkCKkabSEiH7Yk9vAV0mgkGHHPsf58pdcUZlnlwwIJJs1/OzUGZX sQvBpYAlAPKPxqrhQgFJv1vI4Z5gnWKVg7j+xK8GeuCmzflIBtHVFrfAi7D57SfT zqtIHQPAgmBkZtiWh7VnQe//Lbd0OFqt6vv3Hhod2D3cgf4tNwkmbcDPqse+X09s Bn4s5rgG8a9Vk/19Yz7h1rK60cY18H48UpphtuxTFP8Hx8ImCF1BxGCuH2lzJpll 5+xq2TzTWWsPWDKoGY0ZbwKkXIhpkkWhvBgkqgkQIildk+2XsmyjflWq51VzkAy3 BPC+BDbq71yUBDP1bqCW2+PWf/bNzdH750XHX3q4C3OrOmlxkMpvUeWoaolpOlcw hCOmhs1wP0boAM9N/5voljuGEzhnNtemgAPa8Xz+5R63v4LXtaFLjmxrXIREi02Y MQscfeJSFZ8IlnbrkNhE0bbYfPuAgsnfXrblNW7BCyeruAZj315jV3gVeMjadnXK vbL3/udU7fmY1RYOyCAREDw8vTbAkIjHKBFEcQ6Xw5kicd0J9P6nyMVjVQ+3/8an 4sCXxAC/cGC2EZPN0hXjP6yWa692/MwSLopedt5yKrjMFaLgJcV2pMlOW4UwIvmp 8i1Acn0TsLp8G/63yoE5 =lFV4 -----END PGP SIGNATURE----- --tpXFRyzAyQ/GSAaD-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 0/4] simplefb: Add regulator handling support Date: Fri, 23 Oct 2015 08:05:45 +0200 Message-ID: <20151023060545.GE10947@lukather> References: <1445572241-13259-1-git-send-email-wens@csie.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tpXFRyzAyQ/GSAaD" Return-path: Content-Disposition: inline In-Reply-To: <1445572241-13259-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chen-Yu Tsai Cc: Hans de Goede , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Brown List-Id: devicetree@vger.kernel.org --tpXFRyzAyQ/GSAaD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 23, 2015 at 11:50:37AM +0800, Chen-Yu Tsai wrote: > Hi everyone, >=20 > This is v4 of the simplefb regulator support series. This series adds > regulator claiming and enabling support for simplefb. >=20 > Changes since v4: > - Fixed inverted logic when testing the property name. > - Fixed regulator supply name string copy length off by 1. > - Added real world user, MSI Primo 81 dts patches. >=20 > Changes since v3: > - Dropped extra "if" which is always true, leftover from v1. > - Updated commit message of patch 1 >=20 > Sometimes the simplefb display output path consits of external conversion > chips and/or LCD drivers and backlights. These devices normally have > GPIOs to turn them on and/or bring them out of reset, and regulators > supplying power to them. >=20 > While the kernel does not touch unclaimed GPIOs, the regulator core > happily disables unused regulators. Thus we need simplefb to claim > and enable the regulators used throughout the display pipeline. >=20 > The binding supports any named regulator supplies under its device > node. The driver will look through its properties, and claim any > regulators by matching "*-supply", as Mark suggested. >=20 > I've not done a generic helper in the regulator core yet, instead doing > the regulator property handling in the simplefb code for now. >=20 >=20 > Patch 1 adds the regulator properties to the DT binding. >=20 > Patch 2 adds code to the simplefb driver to claim and enable regulators. > Hans, I dropped your Reviewed-by tag from this patch. >=20 > Patch 3 adds labels to the simplefb device nodes in sun6i-a31.dtsi > so we can reference them in the board dts files, like in the next > patch. >=20 > Patch 4 adds a dts file for MSI's Primo 81 tablet. Applied 3 and 4. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --tpXFRyzAyQ/GSAaD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWKc45AAoJEBx+YmzsjxAguikP/1rkc7+H/3E0XZTRo1GqEERc iOdaJKIEhRD/OkCKkabSEiH7Yk9vAV0mgkGHHPsf58pdcUZlnlwwIJJs1/OzUGZX sQvBpYAlAPKPxqrhQgFJv1vI4Z5gnWKVg7j+xK8GeuCmzflIBtHVFrfAi7D57SfT zqtIHQPAgmBkZtiWh7VnQe//Lbd0OFqt6vv3Hhod2D3cgf4tNwkmbcDPqse+X09s Bn4s5rgG8a9Vk/19Yz7h1rK60cY18H48UpphtuxTFP8Hx8ImCF1BxGCuH2lzJpll 5+xq2TzTWWsPWDKoGY0ZbwKkXIhpkkWhvBgkqgkQIildk+2XsmyjflWq51VzkAy3 BPC+BDbq71yUBDP1bqCW2+PWf/bNzdH750XHX3q4C3OrOmlxkMpvUeWoaolpOlcw hCOmhs1wP0boAM9N/5voljuGEzhnNtemgAPa8Xz+5R63v4LXtaFLjmxrXIREi02Y MQscfeJSFZ8IlnbrkNhE0bbYfPuAgsnfXrblNW7BCyeruAZj315jV3gVeMjadnXK vbL3/udU7fmY1RYOyCAREDw8vTbAkIjHKBFEcQ6Xw5kicd0J9P6nyMVjVQ+3/8an 4sCXxAC/cGC2EZPN0hXjP6yWa692/MwSLopedt5yKrjMFaLgJcV2pMlOW4UwIvmp 8i1Acn0TsLp8G/63yoE5 =lFV4 -----END PGP SIGNATURE----- --tpXFRyzAyQ/GSAaD-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Fri, 23 Oct 2015 06:05:45 +0000 Subject: Re: [PATCH v4 0/4] simplefb: Add regulator handling support Message-Id: <20151023060545.GE10947@lukather> MIME-Version: 1 Content-Type: multipart/mixed; boundary="tpXFRyzAyQ/GSAaD" List-Id: References: <1445572241-13259-1-git-send-email-wens@csie.org> In-Reply-To: <1445572241-13259-1-git-send-email-wens@csie.org> To: linux-arm-kernel@lists.infradead.org --tpXFRyzAyQ/GSAaD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 23, 2015 at 11:50:37AM +0800, Chen-Yu Tsai wrote: > Hi everyone, >=20 > This is v4 of the simplefb regulator support series. This series adds > regulator claiming and enabling support for simplefb. >=20 > Changes since v4: > - Fixed inverted logic when testing the property name. > - Fixed regulator supply name string copy length off by 1. > - Added real world user, MSI Primo 81 dts patches. >=20 > Changes since v3: > - Dropped extra "if" which is always true, leftover from v1. > - Updated commit message of patch 1 >=20 > Sometimes the simplefb display output path consits of external conversion > chips and/or LCD drivers and backlights. These devices normally have > GPIOs to turn them on and/or bring them out of reset, and regulators > supplying power to them. >=20 > While the kernel does not touch unclaimed GPIOs, the regulator core > happily disables unused regulators. Thus we need simplefb to claim > and enable the regulators used throughout the display pipeline. >=20 > The binding supports any named regulator supplies under its device > node. The driver will look through its properties, and claim any > regulators by matching "*-supply", as Mark suggested. >=20 > I've not done a generic helper in the regulator core yet, instead doing > the regulator property handling in the simplefb code for now. >=20 >=20 > Patch 1 adds the regulator properties to the DT binding. >=20 > Patch 2 adds code to the simplefb driver to claim and enable regulators. > Hans, I dropped your Reviewed-by tag from this patch. >=20 > Patch 3 adds labels to the simplefb device nodes in sun6i-a31.dtsi > so we can reference them in the board dts files, like in the next > patch. >=20 > Patch 4 adds a dts file for MSI's Primo 81 tablet. Applied 3 and 4. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --tpXFRyzAyQ/GSAaD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWKc45AAoJEBx+YmzsjxAguikP/1rkc7+H/3E0XZTRo1GqEERc iOdaJKIEhRD/OkCKkabSEiH7Yk9vAV0mgkGHHPsf58pdcUZlnlwwIJJs1/OzUGZX sQvBpYAlAPKPxqrhQgFJv1vI4Z5gnWKVg7j+xK8GeuCmzflIBtHVFrfAi7D57SfT zqtIHQPAgmBkZtiWh7VnQe//Lbd0OFqt6vv3Hhod2D3cgf4tNwkmbcDPqse+X09s Bn4s5rgG8a9Vk/19Yz7h1rK60cY18H48UpphtuxTFP8Hx8ImCF1BxGCuH2lzJpll 5+xq2TzTWWsPWDKoGY0ZbwKkXIhpkkWhvBgkqgkQIildk+2XsmyjflWq51VzkAy3 BPC+BDbq71yUBDP1bqCW2+PWf/bNzdH750XHX3q4C3OrOmlxkMpvUeWoaolpOlcw hCOmhs1wP0boAM9N/5voljuGEzhnNtemgAPa8Xz+5R63v4LXtaFLjmxrXIREi02Y MQscfeJSFZ8IlnbrkNhE0bbYfPuAgsnfXrblNW7BCyeruAZj315jV3gVeMjadnXK vbL3/udU7fmY1RYOyCAREDw8vTbAkIjHKBFEcQ6Xw5kicd0J9P6nyMVjVQ+3/8an 4sCXxAC/cGC2EZPN0hXjP6yWa692/MwSLopedt5yKrjMFaLgJcV2pMlOW4UwIvmp 8i1Acn0TsLp8G/63yoE5 =lFV4 -----END PGP SIGNATURE----- --tpXFRyzAyQ/GSAaD-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Fri, 23 Oct 2015 08:05:45 +0200 Subject: [PATCH v4 0/4] simplefb: Add regulator handling support In-Reply-To: <1445572241-13259-1-git-send-email-wens@csie.org> References: <1445572241-13259-1-git-send-email-wens@csie.org> Message-ID: <20151023060545.GE10947@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 23, 2015 at 11:50:37AM +0800, Chen-Yu Tsai wrote: > Hi everyone, > > This is v4 of the simplefb regulator support series. This series adds > regulator claiming and enabling support for simplefb. > > Changes since v4: > - Fixed inverted logic when testing the property name. > - Fixed regulator supply name string copy length off by 1. > - Added real world user, MSI Primo 81 dts patches. > > Changes since v3: > - Dropped extra "if" which is always true, leftover from v1. > - Updated commit message of patch 1 > > Sometimes the simplefb display output path consits of external conversion > chips and/or LCD drivers and backlights. These devices normally have > GPIOs to turn them on and/or bring them out of reset, and regulators > supplying power to them. > > While the kernel does not touch unclaimed GPIOs, the regulator core > happily disables unused regulators. Thus we need simplefb to claim > and enable the regulators used throughout the display pipeline. > > The binding supports any named regulator supplies under its device > node. The driver will look through its properties, and claim any > regulators by matching "*-supply", as Mark suggested. > > I've not done a generic helper in the regulator core yet, instead doing > the regulator property handling in the simplefb code for now. > > > Patch 1 adds the regulator properties to the DT binding. > > Patch 2 adds code to the simplefb driver to claim and enable regulators. > Hans, I dropped your Reviewed-by tag from this patch. > > Patch 3 adds labels to the simplefb device nodes in sun6i-a31.dtsi > so we can reference them in the board dts files, like in the next > patch. > > Patch 4 adds a dts file for MSI's Primo 81 tablet. Applied 3 and 4. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: